components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 2318533002: [Password Generation] Use signatures for form matching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index e5695a03c36dff87bdcf49efc1d7b34d8028f3ee..6ebf24c0b25b7a0f9c32ed234a6e68bd363aadf8 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -755,7 +755,7 @@ TEST_F(AutofillMetricsTest, QualityMetrics_BasedOnAutocomplete) {

ASSERT_TRUE(response.SerializeToString(&response_string));

std::vector<std::string> signatures;

- signatures.push_back(form_structure->FormSignature());

+ signatures.push_back(form_structure->FormSignatureAsStr());

base::HistogramTester histogram_tester;

autofill_manager_->OnLoadedServerPredictions(response_string, signatures);