Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: components/autofill/content/public/cpp/autofill_types_struct_traits.h

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/public/cpp/autofill_types_struct_traits.h
diff --git a/components/autofill/content/public/cpp/autofill_types_struct_traits.h b/components/autofill/content/public/cpp/autofill_types_struct_traits.h
index e68b93abb579344a72ab9a33e978375d3f032488..e22085f1bbf7c77ef1319a7db474b4b4f8a9abec 100644
--- a/components/autofill/content/public/cpp/autofill_types_struct_traits.h
+++ b/components/autofill/content/public/cpp/autofill_types_struct_traits.h
@@ -365,18 +365,14 @@ struct StructTraits<autofill::mojom::PasswordFormFillDataDataView,
template <>
struct StructTraits<autofill::mojom::PasswordFormGenerationDataDataView,
autofill::PasswordFormGenerationData> {
- static const base::string16& name(
+ static uint64_t form_signature(
const autofill::PasswordFormGenerationData& r) {
- return r.name;
- }
-
- static const GURL& action(const autofill::PasswordFormGenerationData& r) {
- return r.action;
+ return r.form_signature;
}
- static const autofill::FormFieldData& generation_field(
+ static uint32_t field_signature(
const autofill::PasswordFormGenerationData& r) {
- return r.generation_field;
+ return r.field_signature;
}
static bool Read(autofill::mojom::PasswordFormGenerationDataDataView data,

Powered by Google App Engine
This is Rietveld 408576698