components/password_manager/core/browser/browser_save_password_progress_logger.cc - Issue 2318533002: [Password Generation] Use signatures for form matching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/browser_save_password_progress_logger.cc

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/signatures_util.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/browser_save_password_progress_logger.cc

diff --git a/components/password_manager/core/browser/browser_save_password_progress_logger.cc b/components/password_manager/core/browser/browser_save_password_progress_logger.cc

index a7d01dc97ee76bfac44f6250e8fa18186009cfb7..c15455e0c581e892f02d9e0bb4971c99a4585552 100644

--- a/components/password_manager/core/browser/browser_save_password_progress_logger.cc

+++ b/components/password_manager/core/browser/browser_save_password_progress_logger.cc

@@ -37,7 +37,7 @@ void BrowserSavePasswordProgressLogger::LogFormSignatures(

autofill::FormStructure form_structure(form.form_data);

std::string message = GetStringFromID(label) + ": {\n";

message += GetStringFromID(STRING_FORM_SIGNATURE) + ": " +

- ScrubNonDigit(form_structure.FormSignature()) + "\n";

+ ScrubNonDigit(form_structure.FormSignatureAsStr()) + "\n";

message += GetStringFromID(STRING_SIGNON_REALM) + ": " +

ScrubURL(GURL(form.signon_realm)) + "\n";

message +=

@@ -50,8 +50,8 @@ void BrowserSavePasswordProgressLogger::LogFormSignatures(

for (const autofill::AutofillField* field : form_structure) {

std::string field_info = ScrubElementID(field->name) + ": " +

- ScrubNonDigit(field->FieldSignature()) + ", " +

- ScrubElementID(field->form_control_type);

+ ScrubNonDigit(field->FieldSignatureAsStr()) +

+ ", " + ScrubElementID(field->form_control_type);

if (!field->autocomplete_attribute.empty())

field_info += ", " + ScrubElementID(field->autocomplete_attribute);

message += field_info + "\n";