Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: components/autofill/content/public/cpp/autofill_types_struct_traits.h

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_PUBLIC_INTERFACES_AUTOFILL_TYPES_STRUCT_TRAI TS_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_PUBLIC_INTERFACES_AUTOFILL_TYPES_STRUCT_TRAI TS_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_PUBLIC_INTERFACES_AUTOFILL_TYPES_STRUCT_TRAI TS_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_PUBLIC_INTERFACES_AUTOFILL_TYPES_STRUCT_TRAI TS_H_
7 7
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 return r.is_possible_change_password_form; 358 return r.is_possible_change_password_form;
359 } 359 }
360 360
361 static bool Read(autofill::mojom::PasswordFormFillDataDataView data, 361 static bool Read(autofill::mojom::PasswordFormFillDataDataView data,
362 autofill::PasswordFormFillData* out); 362 autofill::PasswordFormFillData* out);
363 }; 363 };
364 364
365 template <> 365 template <>
366 struct StructTraits<autofill::mojom::PasswordFormGenerationDataDataView, 366 struct StructTraits<autofill::mojom::PasswordFormGenerationDataDataView,
367 autofill::PasswordFormGenerationData> { 367 autofill::PasswordFormGenerationData> {
368 static const base::string16& name( 368 static uint64_t form_signature(
369 const autofill::PasswordFormGenerationData& r) { 369 const autofill::PasswordFormGenerationData& r) {
370 return r.name; 370 return r.form_signature;
371 } 371 }
372 372
373 static const GURL& action(const autofill::PasswordFormGenerationData& r) { 373 static uint32_t field_signature(
374 return r.action;
375 }
376
377 static const autofill::FormFieldData& generation_field(
378 const autofill::PasswordFormGenerationData& r) { 374 const autofill::PasswordFormGenerationData& r) {
379 return r.generation_field; 375 return r.field_signature;
380 } 376 }
381 377
382 static bool Read(autofill::mojom::PasswordFormGenerationDataDataView data, 378 static bool Read(autofill::mojom::PasswordFormGenerationDataDataView data,
383 autofill::PasswordFormGenerationData* out); 379 autofill::PasswordFormGenerationData* out);
384 }; 380 };
385 381
386 template <> 382 template <>
387 struct StructTraits<autofill::mojom::PasswordFormDataView, 383 struct StructTraits<autofill::mojom::PasswordFormDataView,
388 autofill::PasswordForm> { 384 autofill::PasswordForm> {
389 static autofill::PasswordForm::Scheme scheme( 385 static autofill::PasswordForm::Scheme scheme(
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 return static_cast<KeysValuesPair*>(context)->second; 582 return static_cast<KeysValuesPair*>(context)->second;
587 } 583 }
588 584
589 static bool Read(autofill::mojom::FormsPredictionsMapDataView data, 585 static bool Read(autofill::mojom::FormsPredictionsMapDataView data,
590 autofill::FormsPredictionsMap* out); 586 autofill::FormsPredictionsMap* out);
591 }; 587 };
592 588
593 } // namespace mojo 589 } // namespace mojo
594 590
595 #endif // COMPONENTS_AUTOFILL_CONTENT_PUBLIC_INTERFACES_AUTOFILL_TYPES_STRUCT_T RAITS_H_ 591 #endif // COMPONENTS_AUTOFILL_CONTENT_PUBLIC_INTERFACES_AUTOFILL_TYPES_STRUCT_T RAITS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698