Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 22900008: Make vw/vh units to work in css transforms.

Created:
5 years, 10 months ago by Srini
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, jamesr, eae+blinkwatch, leviw+renderwatch, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney, jeez, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make vw/vh units to work in css transforms. RenderView object isn't available to calculate viewport size when the transforms are expanding the percentage to real size. Pass the RenderView object to the Transform object's apply() and blend() functions accordingly. And also to Graphics layer and RenderStyle objects for addAnimation and applyTransforms. BUG=137617

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -87 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.h View 2 chunks +2 lines, -1 line 1 comment Download
M Source/core/platform/graphics/GraphicsLayer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/chromium/AnimationTranslationUtil.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/platform/graphics/chromium/AnimationTranslationUtil.cpp View 9 chunks +17 lines, -17 lines 0 comments Download
M Source/core/platform/graphics/chromium/AnimationTranslationUtilTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/custom/CustomFilterTransformParameter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/transforms/IdentityTransformOperation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/InterpolatedTransformOperation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/InterpolatedTransformOperation.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/platform/graphics/transforms/Matrix3DTransformOperation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/Matrix3DTransformOperation.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/transforms/MatrixTransformOperation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/MatrixTransformOperation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/transforms/PerspectiveTransformOperation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/transforms/PerspectiveTransformOperation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/transforms/RotateTransformOperation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/RotateTransformOperation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/transforms/ScaleTransformOperation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/ScaleTransformOperation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/transforms/SkewTransformOperation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/SkewTransformOperation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/transforms/TransformOperation.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/TransformOperations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/transforms/TranslateTransformOperation.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/graphics/transforms/TranslateTransformOperation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 6 chunks +9 lines, -7 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Srini
Can you review this patch? I would be happy to fix any issues needs to ...
5 years, 10 months ago (2013-08-16 20:35:59 UTC) #1
Srini
This patch fixes the bug it advertises, but I guess it also fixes some other ...
5 years, 10 months ago (2013-08-16 20:40:02 UTC) #2
adamk
Kent & I are definitely not the best reviewers for this code; hopefully jamesr will ...
5 years, 10 months ago (2013-08-16 21:27:34 UTC) #3
Srini
jamesr: Can you look at this patch? Thanks!
5 years, 10 months ago (2013-08-17 15:23:10 UTC) #4
jamesr
https://codereview.chromium.org/22900008/diff/1/Source/core/platform/graphics/GraphicsLayer.h File Source/core/platform/graphics/GraphicsLayer.h (right): https://codereview.chromium.org/22900008/diff/1/Source/core/platform/graphics/GraphicsLayer.h#newcode66 Source/core/platform/graphics/GraphicsLayer.h:66: class RenderView; No. RenderView is a core/rendering/ concept and ...
5 years, 10 months ago (2013-08-19 03:19:49 UTC) #5
jamesr
Viewport size changes are rare relative to things changing in the page. Can't we just ...
5 years, 10 months ago (2013-08-19 03:21:08 UTC) #6
jamesr
I.e. exactly what was proposed here for gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=503720#c17
5 years, 10 months ago (2013-08-19 03:22:39 UTC) #7
Srini
On 2013/08/19 03:22:39, jamesr wrote: > I.e. exactly what was proposed here for gecko: > ...
5 years, 10 months ago (2013-08-19 07:39:10 UTC) #8
Srini
On 2013/08/19 07:39:10, Srini wrote: > On 2013/08/19 03:22:39, jamesr wrote: > > I.e. exactly ...
5 years, 10 months ago (2013-08-19 19:32:00 UTC) #9
Srini
On 2013/08/19 19:32:00, Srini wrote: > On 2013/08/19 07:39:10, Srini wrote: > > On 2013/08/19 ...
5 years, 10 months ago (2013-08-20 20:25:59 UTC) #10
jamesr
Please file a bug or start a discussion on blink-dev@ about how to do this. ...
5 years, 10 months ago (2013-08-20 20:26:37 UTC) #11
Srini
On 2013/08/20 20:26:37, jamesr wrote: > Please file a bug or start a discussion on ...
5 years, 10 months ago (2013-08-20 20:35:04 UTC) #12
jamesr
Sounds great. Thanks for looking into this!
5 years, 10 months ago (2013-08-20 20:40:40 UTC) #13
Srini
On 2013/08/20 20:40:40, jamesr wrote: > Sounds great. Thanks for looking into this! Anytime! (btw, ...
5 years, 10 months ago (2013-08-20 20:45:52 UTC) #14
Srini
On 2013/08/20 20:45:52, Srini wrote: > On 2013/08/20 20:40:40, jamesr wrote: > > Sounds great. ...
5 years, 9 months ago (2013-09-17 11:18:45 UTC) #15
jamesr
5 years, 9 months ago (2013-09-18 00:57:08 UTC) #16
Please take this discussion to blink-dev - there are many people who are
probably equipped than me to give you feedback on the design and code reviews
are awkward places to have in-depth discussions.

Powered by Google App Engine
This is Rietveld 408576698