Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed)

Created:
4 years, 3 months ago by sullivan
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, jochen+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: merge devtools target with devtools host, part 1 (patchset #14 id:260001 of https://codereview.chromium.org/2263843002/ ) Reason for revert: Caused crashes on all WebView telemetry tests. See crbug.com/641390. Original issue's description: > DevTools: merge devtools target with devtools host, part 1 > > BUG=627517 > TBR= > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a > Cr-Commit-Position: refs/heads/master@{#414707} TBR=dgozman@chromium.org,asargent@chromium.org,skyostil@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=627517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+924 lines, -804 lines) Patch
M android_webview/browser/aw_dev_tools_discovery_provider.cc View 2 chunks +21 lines, -5 lines 0 comments Download
M chrome/browser/android/dev_tools_discovery_provider_android.cc View 6 chunks +115 lines, -99 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_discovery_provider.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 3 chunks +10 lines, -92 lines 0 comments Download
M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 9 chunks +162 lines, -166 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.h View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.cc View 2 chunks +201 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 3 chunks +14 lines, -18 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 2 chunks +20 lines, -23 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 6 chunks +12 lines, -14 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.h View 1 chunk +32 lines, -0 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.cc View 1 chunk +78 lines, -1 line 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_discovery/devtools_target_descriptor.h View 1 chunk +33 lines, -0 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 8 chunks +16 lines, -18 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 3 chunks +5 lines, -8 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 6 chunks +12 lines, -43 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 3 chunks +23 lines, -41 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.h View 1 chunk +1 line, -7 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.cc View 2 chunks +7 lines, -20 lines 0 comments Download
M content/browser/devtools/protocol/browser_handler.cc View 3 chunks +24 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 3 chunks +22 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 chunk +1 line, -8 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 6 chunks +9 lines, -57 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/devtools/shared_worker_devtools_agent_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/devtools/shared_worker_devtools_agent_host.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/devtools/site_per_process_devtools_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/devtools_agent_host.h View 4 chunks +20 lines, -30 lines 0 comments Download
M content/public/browser/devtools_external_agent_proxy_delegate.h View 1 chunk +7 lines, -37 lines 0 comments Download
M content/public/browser/devtools_manager_delegate.h View 2 chunks +2 lines, -10 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
sullivan
Created Revert of DevTools: merge devtools target with devtools host, part 1
4 years, 3 months ago (2016-08-29 14:20:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289773002/1
4 years, 3 months ago (2016-08-29 14:21:08 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 14:23:38 UTC) #5
Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698