chrome/browser/devtools/devtools_window.cc - Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index c35f629827ff94a812edac303cf71396a3c6ff0e..b1b36d427837f83de2e4de30f48a702788ef8e62 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -563,7 +563,7 @@

base::TimeTicks start_time = base::TimeTicks::Now();

// TODO(loislo): we should initiate DevTools window opening from within

// renderer. Otherwise, we still can hit a race condition here.

- if (agent->GetType() == content::DevToolsAgentHost::kTypePage) {

+ if (agent->GetType() == content::DevToolsAgentHost::TYPE_WEB_CONTENTS) {

OpenDevToolsWindow(agent->GetWebContents());

} else {

OpenDevToolsWindow(Profile::FromBrowserContext(agent->GetBrowserContext()),

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »