chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc - Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('k') | chrome/browser/devtools/device/devtools_android_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

index dd5a92625c61dcb85586b9bcc1f6a18a2a00d3e1..341c1b6b81fdbefd91e4896ed6c62b9f0f094757 100644

--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

@@ -118,15 +118,15 @@

android_bridge_->CreatePageTarget(webview_pages[1]));

// Check that we have non-empty description for webview pages.

- ASSERT_EQ(0U, chrome_target->GetAgentHost()->GetDescription().size());

- ASSERT_EQ(0U, chrome_beta_target->GetAgentHost()->GetDescription().size());

- ASSERT_NE(0U, webview_target_0->GetAgentHost()->GetDescription().size());

- ASSERT_NE(0U, webview_target_1->GetAgentHost()->GetDescription().size());

+ ASSERT_EQ(0U, chrome_target->GetDescription().size());

+ ASSERT_EQ(0U, chrome_beta_target->GetDescription().size());

+ ASSERT_NE(0U, webview_target_0->GetDescription().size());

+ ASSERT_NE(0U, webview_target_1->GetDescription().size());

ASSERT_EQ(GURL("http://www.chromium.org/"),

- chrome_target->GetAgentHost()->GetURL());

+ chrome_target->GetURL());

ASSERT_EQ("The Chromium Projects",

- chrome_target->GetAgentHost()->GetTitle());

+ chrome_target->GetTitle());

}

private: