Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: content/browser/devtools/browser_devtools_agent_host.cc

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/browser_devtools_agent_host.cc
diff --git a/content/browser/devtools/browser_devtools_agent_host.cc b/content/browser/devtools/browser_devtools_agent_host.cc
index 668976a89e81ebb3bf595b286dc9b7ca19ac1dec..0e2835072f6f8a08d43d63997bdef5bb9498150f 100644
--- a/content/browser/devtools/browser_devtools_agent_host.cc
+++ b/content/browser/devtools/browser_devtools_agent_host.cc
@@ -5,7 +5,6 @@
#include "content/browser/devtools/browser_devtools_agent_host.h"
#include "base/bind.h"
-#include "base/guid.h"
#include "content/browser/devtools/devtools_protocol_handler.h"
#include "content/browser/devtools/protocol/browser_handler.h"
#include "content/browser/devtools/protocol/io_handler.h"
@@ -26,8 +25,7 @@
BrowserDevToolsAgentHost::BrowserDevToolsAgentHost(
scoped_refptr<base::SingleThreadTaskRunner> tethering_task_runner,
const CreateServerSocketCallback& socket_callback)
- : DevToolsAgentHostImpl(base::GenerateGUID()),
- browser_handler_(new devtools::browser::BrowserHandler()),
+ : browser_handler_(new devtools::browser::BrowserHandler()),
io_handler_(new devtools::io::IOHandler(GetIOContext())),
memory_handler_(new devtools::memory::MemoryHandler()),
system_info_handler_(new devtools::system_info::SystemInfoHandler()),
@@ -57,8 +55,8 @@
void BrowserDevToolsAgentHost::Detach() {
}
-std::string BrowserDevToolsAgentHost::GetType() {
- return kTypeBrowser;
+DevToolsAgentHost::Type BrowserDevToolsAgentHost::GetType() {
+ return TYPE_BROWSER;
}
std::string BrowserDevToolsAgentHost::GetTitle() {
@@ -73,15 +71,8 @@
return false;
}
-bool BrowserDevToolsAgentHost::Inspect() {
- return false;
-}
-
bool BrowserDevToolsAgentHost::Close() {
return false;
-}
-
-void BrowserDevToolsAgentHost::Reload() {
}
bool BrowserDevToolsAgentHost::DispatchProtocolMessage(
« no previous file with comments | « content/browser/devtools/browser_devtools_agent_host.h ('k') | content/browser/devtools/devtools_agent_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698