Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/device/adb/adb_device_provider.h" 5 #include "chrome/browser/devtools/device/adb/adb_device_provider.h"
6 #include "chrome/browser/devtools/device/adb/mock_adb_server.h" 6 #include "chrome/browser/devtools/device/adb/mock_adb_server.h"
7 #include "chrome/browser/devtools/device/devtools_android_bridge.h" 7 #include "chrome/browser/devtools/device/devtools_android_bridge.h"
8 #include "chrome/browser/devtools/devtools_target_impl.h" 8 #include "chrome/browser/devtools/devtools_target_impl.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 std::unique_ptr<DevToolsTargetImpl> chrome_target( 111 std::unique_ptr<DevToolsTargetImpl> chrome_target(
112 android_bridge_->CreatePageTarget(chrome_pages[0])); 112 android_bridge_->CreatePageTarget(chrome_pages[0]));
113 std::unique_ptr<DevToolsTargetImpl> chrome_beta_target( 113 std::unique_ptr<DevToolsTargetImpl> chrome_beta_target(
114 android_bridge_->CreatePageTarget(chrome_beta_pages[0])); 114 android_bridge_->CreatePageTarget(chrome_beta_pages[0]));
115 std::unique_ptr<DevToolsTargetImpl> webview_target_0( 115 std::unique_ptr<DevToolsTargetImpl> webview_target_0(
116 android_bridge_->CreatePageTarget(webview_pages[0])); 116 android_bridge_->CreatePageTarget(webview_pages[0]));
117 std::unique_ptr<DevToolsTargetImpl> webview_target_1( 117 std::unique_ptr<DevToolsTargetImpl> webview_target_1(
118 android_bridge_->CreatePageTarget(webview_pages[1])); 118 android_bridge_->CreatePageTarget(webview_pages[1]));
119 119
120 // Check that we have non-empty description for webview pages. 120 // Check that we have non-empty description for webview pages.
121 ASSERT_EQ(0U, chrome_target->GetAgentHost()->GetDescription().size()); 121 ASSERT_EQ(0U, chrome_target->GetDescription().size());
122 ASSERT_EQ(0U, chrome_beta_target->GetAgentHost()->GetDescription().size()); 122 ASSERT_EQ(0U, chrome_beta_target->GetDescription().size());
123 ASSERT_NE(0U, webview_target_0->GetAgentHost()->GetDescription().size()); 123 ASSERT_NE(0U, webview_target_0->GetDescription().size());
124 ASSERT_NE(0U, webview_target_1->GetAgentHost()->GetDescription().size()); 124 ASSERT_NE(0U, webview_target_1->GetDescription().size());
125 125
126 ASSERT_EQ(GURL("http://www.chromium.org/"), 126 ASSERT_EQ(GURL("http://www.chromium.org/"),
127 chrome_target->GetAgentHost()->GetURL()); 127 chrome_target->GetURL());
128 ASSERT_EQ("The Chromium Projects", 128 ASSERT_EQ("The Chromium Projects",
129 chrome_target->GetAgentHost()->GetTitle()); 129 chrome_target->GetTitle());
130 } 130 }
131 131
132 private: 132 private:
133 DevToolsAndroidBridge* android_bridge_; 133 DevToolsAndroidBridge* android_bridge_;
134 DevToolsAndroidBridge::RemoteDevices devices_; 134 DevToolsAndroidBridge::RemoteDevices devices_;
135 }; 135 };
136 136
137 // Flaky due to failure to bind a hardcoded port. crbug.com/566057 137 // Flaky due to failure to bind a hardcoded port. crbug.com/566057
138 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, DISABLED_TestFlushWithoutSize) { 138 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, DISABLED_TestFlushWithoutSize) {
139 StartMockAdbServer(FlushWithoutSize); 139 StartMockAdbServer(FlushWithoutSize);
(...skipping 10 matching lines...) Expand all
150 StopMockAdbServer(); 150 StopMockAdbServer();
151 } 151 }
152 152
153 // Flaky due to failure to bind a hardcoded port. crbug.com/566057 153 // Flaky due to failure to bind a hardcoded port. crbug.com/566057
154 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, DISABLED_TestFlushWithData) { 154 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, DISABLED_TestFlushWithData) {
155 StartMockAdbServer(FlushWithData); 155 StartMockAdbServer(FlushWithData);
156 StartTest(); 156 StartTest();
157 CheckDevices(); 157 CheckDevices();
158 StopMockAdbServer(); 158 StopMockAdbServer();
159 } 159 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('k') | chrome/browser/devtools/device/devtools_android_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698