Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: content/public/browser/devtools_agent_host.h

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_agent_host.h
diff --git a/content/public/browser/devtools_agent_host.h b/content/public/browser/devtools_agent_host.h
index e98f5dc9845f7e64082f82837d3821ee33e64dc7..33d341cfd46085a51a73c823d8569a19ca9a9095 100644
--- a/content/public/browser/devtools_agent_host.h
+++ b/content/public/browser/devtools_agent_host.h
@@ -11,7 +11,6 @@
#include "base/callback.h"
#include "base/memory/ref_counted.h"
-#include "base/time/time.h"
#include "content/common/content_export.h"
#include "content/public/browser/devtools_agent_host_client.h"
#include "url/gurl.h"
@@ -35,13 +34,25 @@
class CONTENT_EXPORT DevToolsAgentHost
: public base::RefCounted<DevToolsAgentHost> {
public:
- static char kTypePage[];
- static char kTypeFrame[];
- static char kTypeSharedWorker[];
- static char kTypeServiceWorker[];
- static char kTypeExternal[];
- static char kTypeBrowser[];
- static char kTypeOther[];
+ enum Type {
+ // Agent host associated with WebContents.
+ TYPE_WEB_CONTENTS,
+
+ // Agent host associated with RenderFrameHost.
+ TYPE_FRAME,
+
+ // Agent host associated with shared worker.
+ TYPE_SHARED_WORKER,
+
+ // Agent host associated with service worker.
+ TYPE_SERVICE_WORKER,
+
+ // Agent host associated with DevToolsExternalAgentProxyDelegate.
+ TYPE_EXTERNAL,
+
+ // Agent host associated with browser.
+ TYPE_BROWSER,
+ };
// Latest DevTools protocol version supported.
static std::string GetProtocolVersion();
@@ -125,9 +136,6 @@
// Returns the unique id of the agent.
virtual std::string GetId() = 0;
- // Returns the id of the parent host, or empty string if no parent.
- virtual std::string GetParentId() = 0;
-
// Returns web contents instance for this host if any.
virtual WebContents* GetWebContents() = 0;
@@ -142,37 +150,19 @@
virtual void ConnectWebContents(WebContents* web_contents) = 0;
// Returns agent host type.
- virtual std::string GetType() = 0;
+ virtual Type GetType() = 0;
// Returns agent host title.
virtual std::string GetTitle() = 0;
- // Returns the host description.
- virtual std::string GetDescription() = 0;
-
- // Override host description.
- virtual void SetDescriptionOverride(const std::string& description) = 0;
-
// Returns url associated with agent host.
virtual GURL GetURL() = 0;
-
- // Returns the favicon url for this host.
- virtual GURL GetFaviconURL() = 0;
// Activates agent host. Returns false if the operation failed.
virtual bool Activate() = 0;
- // Opens devtools for this agent host. Returns false if the operation failed.
- virtual bool Inspect() = 0;
-
- // Reloads the host.
- virtual void Reload() = 0;
-
// Closes agent host. Returns false if the operation failed.
virtual bool Close() = 0;
-
- // Returns the time when the host was last active.
- virtual base::TimeTicks GetLastActivityTime() = 0;
// Terminates all debugging sessions and detaches all clients.
static void DetachAllClients();

Powered by Google App Engine
This is Rietveld 408576698