headless/lib/browser/headless_devtools_manager_delegate.cc - Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_devtools_manager_delegate.cc

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « headless/lib/browser/headless_devtools_manager_delegate.h ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/lib/browser/headless_devtools_manager_delegate.cc

diff --git a/headless/lib/browser/headless_devtools_manager_delegate.cc b/headless/lib/browser/headless_devtools_manager_delegate.cc

index adc2c5ef92ee1bd4a34dc58bf3c8cf08e72335a6..338c5cc90a347642182641d6acfce2c78a9bd202 100644

--- a/headless/lib/browser/headless_devtools_manager_delegate.cc

+++ b/headless/lib/browser/headless_devtools_manager_delegate.cc

@@ -8,7 +8,6 @@

#include <utility>

#include "content/public/browser/browser_thread.h"

-#include "content/public/browser/devtools_agent_host.h"

#include "content/public/browser/web_contents.h"

#include "headless/lib/browser/headless_browser_context_impl.h"

#include "headless/lib/browser/headless_browser_impl.h"

@@ -60,16 +59,6 @@

result->SetInteger("id", id);

result->Set("result", std::move(cmd_result));

return result.release();

-std::string HeadlessDevToolsManagerDelegate::GetTargetType(

- content::RenderFrameHost* host) {

- return content::DevToolsAgentHost::kTypePage;

-std::string HeadlessDevToolsManagerDelegate::GetTargetTitle(

- content::RenderFrameHost* host) {

- return "";

}

std::unique_ptr<base::Value> HeadlessDevToolsManagerDelegate::CreateTarget(