content/public/browser/devtools_manager_delegate.h - Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/devtools_manager_delegate.h

Issue 2289773002: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/devtools_external_agent_proxy_delegate.h ('k') | content/shell/browser/shell_devtools_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/devtools_manager_delegate.h

diff --git a/content/public/browser/devtools_manager_delegate.h b/content/public/browser/devtools_manager_delegate.h

index 4d929292ac5b42663495fe28193414788bf347ec..d34e7af3957ed5eea0cc835fb73cb348f45b4f4c 100644

--- a/content/public/browser/devtools_manager_delegate.h

+++ b/content/public/browser/devtools_manager_delegate.h

@@ -4,8 +4,6 @@

#ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_

#define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_

-#include <string>

namespace base {

class DictionaryValue;

@@ -15,23 +13,17 @@

class BrowserContext;

class DevToolsAgentHost;

-class RenderFrameHost;

class DevToolsManagerDelegate {

public:

virtual ~DevToolsManagerDelegate() {}

// Opens the inspector for |agent_host|.

- virtual void Inspect(DevToolsAgentHost* agent_host) = 0;

+ virtual void Inspect(BrowserContext* browser_context,

+ DevToolsAgentHost* agent_host) = 0;

virtual void DevToolsAgentStateChanged(DevToolsAgentHost* agent_host,

bool attached) = 0;

- // Returns DevToolsAgentHost type to use for given |host| target.

- virtual std::string GetTargetType(RenderFrameHost* host) = 0;

- // Returns DevToolsAgentHost title to use for given |host| target.

- virtual std::string GetTargetTitle(RenderFrameHost* host) = 0;

// Result ownership is passed to the caller.

virtual base::DictionaryValue* HandleCommand(