Remove OfflineURL from offline page

Remove OfflineURL from offline page since the concept of offline file URL is deprecated

BUG=641576
Committed: https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915
Cr-Commit-Position: refs/heads/master@{#423299}

[jianli, 2016-08-26 22:31:38]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[jianli, 2016-08-26 22:32:02]

jianli@chromium.org changed reviewers:
+ dewittj@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:33:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:58:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[jianli, 2016-08-26 23:05:52]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 23:06:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 00:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 00:23:30]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[dewittj, 2016-08-31 16:31:39]

this lgtm, with a nit

Please hold off for a week or so before submit to allow for easier merging into
M54.

https://codereview.chromium.org/2284933002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
(left):

https://codereview.chromium.org/2284933002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
why not remove this file as a separate patch?

[jianli, 2016-10-04 23:46:09]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 23:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 23:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 23:56:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jianli, 2016-10-05 00:43:27]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 00:44:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2016-10-05 01:17:00]

jianli@chromium.org changed reviewers:
+ bauerb@chromium.org, treib@chromium.org

[jianli, 2016-10-05 01:17:01]

treib for ntp_snippet changes
bauerb for Java changes and webui changes

[jianli, 2016-10-05 01:17:27]

Description was changed from

==========
Remove OfflineURL from offline page

BUG=641576
==========

to

==========
Remove OfflineURL from offline page since the concept of offline file URL is
deprecated

BUG=641576
==========

[jianli, 2016-10-05 01:19:26]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 01:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 02:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 02:47:42]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-10-05 09:15:23]

+vitaliii FYI

components/ntp_snippets/ lgtm

https://codereview.chromium.org/2284933002/diff/80001/components/ntp_snippets...
File components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
(left):

https://codereview.chromium.org/2284933002/diff/80001/components/ntp_snippets...
components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc:218: //
and not just as a downloaded file.
I guess this TODO kinda still applies, maybe like "Make sure the URL is opened
in the existing tab", something like that?

[Bernhard Bauer, 2016-10-05 10:48:25]

lgtm

[jianli, 2016-10-05 20:34:06]

The CQ bit was checked by jianli@chromium.org

[jianli, 2016-10-05 20:34:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
dewittj@chromium.org, treib@chromium.org, bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2284933002/#ps100001
(title: "Add comment per feedback")

[jianli, 2016-10-05 20:34:16]

https://codereview.chromium.org/2284933002/diff/80001/components/ntp_snippets...
File components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
(left):

https://codereview.chromium.org/2284933002/diff/80001/components/ntp_snippets...
components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc:218: //
and not just as a downloaded file.
On 2016/10/05 09:15:23, Marc Treib wrote:
> I guess this TODO kinda still applies, maybe like "Make sure the URL is opened
> in the existing tab", something like that?

Done.

[commit-bot: I haz the power, 2016-10-05 20:34:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 21:31:21]

Description was changed from

==========
Remove OfflineURL from offline page since the concept of offline file URL is
deprecated

BUG=641576
==========

to

==========
Remove OfflineURL from offline page since the concept of offline file URL is
deprecated

BUG=641576
==========

[commit-bot: I haz the power, 2016-10-05 21:31:22]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-05 21:35:41]

Description was changed from

==========
Remove OfflineURL from offline page since the concept of offline file URL is
deprecated

BUG=641576
==========

to

==========
Remove OfflineURL from offline page since the concept of offline file URL is
deprecated

BUG=641576

Committed: https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915
Cr-Commit-Position: refs/heads/master@{#423299}
==========

[commit-bot: I haz the power, 2016-10-05 21:35:42]

Patchset 6 (id:??) landed as
https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915
Cr-Commit-Position: refs/heads/master@{#423299}