chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc - Issue 2284933002: Remove OfflineURL from offline page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)

Patch Set: Add comment per feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

index bddeb65a6fa1d8cd5f68d83afe284786ba5c1bbb..08d5c1966e9752e61c4c7185d8e0459e287e2749 100644

--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

@@ -142,7 +142,7 @@ void OfflineInternalsUIMessageHandler::HandleStoredPagesCallback(

offline_page->SetString("namespace", page.client_id.name_space);

offline_page->SetDouble("size", page.file_size);

offline_page->SetString("id", std::to_string(page.offline_id));

- offline_page->SetString("filePath", page.GetOfflineURL().spec());

+ offline_page->SetString("filePath", page.file_path.MaybeAsASCII());

offline_page->SetDouble("creationTime", page.creation_time.ToJsTime());

offline_page->SetDouble("lastAccessTime", page.last_access_time.ToJsTime());

offline_page->SetInteger("accessCount", page.access_count);