Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Add comment per feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index 4c22d71c5e105189b53c408190e1dafc5ae66774..b1bffb7f9d725af0126051c44d98fbc6ee7fc31e 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -58,7 +58,6 @@ void ToJavaOfflinePageList(JNIEnv* env,
offline_page.offline_id,
ConvertUTF8ToJavaString(env, offline_page.client_id.name_space),
ConvertUTF8ToJavaString(env, offline_page.client_id.id),
- ConvertUTF8ToJavaString(env, offline_page.GetOfflineURL().spec()),
ConvertUTF8ToJavaString(env, offline_page.file_path.value()),
offline_page.file_size, offline_page.creation_time.ToJavaTime(),
offline_page.access_count, offline_page.last_access_time.ToJavaTime());
@@ -73,7 +72,6 @@ ScopedJavaLocalRef<jobject> ToJavaOfflinePageItem(
offline_page.offline_id,
ConvertUTF8ToJavaString(env, offline_page.client_id.name_space),
ConvertUTF8ToJavaString(env, offline_page.client_id.id),
- ConvertUTF8ToJavaString(env, offline_page.GetOfflineURL().spec()),
ConvertUTF8ToJavaString(env, offline_page.file_path.value()),
offline_page.file_size, offline_page.creation_time.ToJavaTime(),
offline_page.access_count, offline_page.last_access_time.ToJavaTime());
@@ -368,21 +366,6 @@ void OfflinePageBridge::SelectPageForOnlineUrl(
base::Bind(&SingleOfflinePageItemCallback, j_callback_ref));
}
-void OfflinePageBridge::GetPageByOfflineUrl(
- JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- const JavaParamRef<jstring>& j_offline_url,
- const JavaParamRef<jobject>& j_callback_obj) {
- DCHECK(j_callback_obj);
-
- ScopedJavaGlobalRef<jobject> j_callback_ref;
- j_callback_ref.Reset(env, j_callback_obj);
-
- offline_page_model_->GetPageByOfflineURL(
- GURL(ConvertJavaStringToUTF8(env, j_offline_url)),
- base::Bind(&SingleOfflinePageItemCallback, j_callback_ref));
-}
-
void OfflinePageBridge::SavePage(
JNIEnv* env,
const JavaParamRef<jobject>& obj,

Powered by Google App Engine
This is Rietveld 408576698