Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Add comment per feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
index 59e97f81067468a31a8920782b60fa81379406dd..d48c1ff1e770905b4014eb73b76001453f57db9d 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
@@ -126,12 +126,6 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
OfflinePageItem offlinePage = allPages.get(0);
assertEquals("Offline pages count incorrect.", 1, allPages.size());
assertEquals("Offline page item url incorrect.", mTestPage, offlinePage.getUrl());
- assertTrue("Offline page item offline file url doesn't start properly.",
- offlinePage.getOfflineUrl().startsWith("file:///"));
- assertTrue("Offline page item offline file doesn't have the right name.",
- offlinePage.getOfflineUrl().endsWith(".mhtml"));
- assertTrue("Offline page item offline file doesn't have the right name.",
- offlinePage.getOfflineUrl().contains("About"));
// We don't care about the exact file size of the mhtml file:
// - exact file size is not something that the end user sees or cares about
@@ -153,12 +147,6 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
savePage(SavePageResult.SUCCESS, mTestPage);
OfflinePageItem offlinePage = getPageByClientId(BOOKMARK_ID);
assertEquals("Offline page item url incorrect.", mTestPage, offlinePage.getUrl());
- assertTrue("Offline page item offline file url doesn't start properly.",
- offlinePage.getOfflineUrl().startsWith("file:///"));
- assertTrue("Offline page item offline file doesn't have the right name.",
- offlinePage.getOfflineUrl().endsWith(".mhtml"));
- assertTrue("Offline page item offline file doesn't have the right name.",
- offlinePage.getOfflineUrl().contains("About"));
assertNull("Offline page is not supposed to exist",
getPageByClientId(new ClientId(OfflinePageBridge.BOOKMARK_NAMESPACE, "-42")));
}

Powered by Google App Engine
This is Rietveld 408576698