Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Add comment per feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index 5f44742346e5c8d5997cd6b3bb962ca3ed151a81..eae68021667e0b8b7fce7fe43d314f6fcf78686b 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -38,21 +38,11 @@
namespace {
// Looks up the original, online URL of the site requested. The URL from the
-// WebContents may be an offline page or a distilled article which is not
-// appropriate for a home screen shortcut.
+// WebContents may be a distilled article which is not appropriate for a home
+// screen shortcut.
GURL GetShortcutUrl(content::BrowserContext* browser_context,
const GURL& actual_url) {
- GURL original_url =
- dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(actual_url);
-
- // If URL points to an offline content, get original URL.
- GURL online_url =
- offline_pages::OfflinePageUtils::MaybeGetOnlineURLForOfflineURL(
- browser_context, original_url);
- if (online_url.is_valid())
- return online_url;
-
- return original_url;
+ return dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(actual_url);
}
InstallableParams ParamsToPerformInstallableCheck(int ideal_icon_size_in_dp,
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698