Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: components/offline_pages/downloads/download_ui_adapter.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Add comment per feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/downloads/download_ui_adapter.h" 5 #include "components/offline_pages/downloads/download_ui_adapter.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/guid.h" 8 #include "base/guid.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
12 #include "components/offline_pages/client_namespace_constants.h" 12 #include "components/offline_pages/client_namespace_constants.h"
13 #include "components/offline_pages/downloads/download_ui_item.h" 13 #include "components/offline_pages/downloads/download_ui_item.h"
14 #include "components/offline_pages/offline_page_model.h" 14 #include "components/offline_pages/offline_page_model.h"
15 15
16 namespace offline_pages { 16 namespace offline_pages {
17 17
18 namespace { 18 namespace {
19 const char kDownloadUIAdapterKey[] = "download-ui-adapter"; 19 const char kDownloadUIAdapterKey[] = "download-ui-adapter";
20 } 20 }
21 21
22 DownloadUIAdapter::ItemInfo::ItemInfo(const OfflinePageItem& page) 22 DownloadUIAdapter::ItemInfo::ItemInfo(const OfflinePageItem& page)
23 : ui_item(base::MakeUnique<DownloadUIItem>(page)), 23 : ui_item(base::MakeUnique<DownloadUIItem>(page)),
24 offline_id(page.offline_id), 24 offline_id(page.offline_id) {}
25 offline_url(page.GetOfflineURL()) {}
26 25
27 DownloadUIAdapter::ItemInfo::~ItemInfo() {} 26 DownloadUIAdapter::ItemInfo::~ItemInfo() {}
28 27
29 DownloadUIAdapter::DownloadUIAdapter(OfflinePageModel* model) 28 DownloadUIAdapter::DownloadUIAdapter(OfflinePageModel* model)
30 : model_(model), 29 : model_(model),
31 state_(State::NOT_LOADED), 30 state_(State::NOT_LOADED),
32 observers_count_(0), 31 observers_count_(0),
33 weak_ptr_factory_(this) { 32 weak_ptr_factory_(this) {
34 } 33 }
35 34
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 } 208 }
210 209
211 // static 210 // static
212 bool DownloadUIAdapter::IsVisibleInUI(const ClientId& client_id) { 211 bool DownloadUIAdapter::IsVisibleInUI(const ClientId& client_id) {
213 const std::string& name_space = client_id.name_space; 212 const std::string& name_space = client_id.name_space;
214 return (name_space == kAsyncNamespace || name_space == kDownloadNamespace) && 213 return (name_space == kAsyncNamespace || name_space == kDownloadNamespace) &&
215 base::IsValidGUID(client_id.id); 214 base::IsValidGUID(client_id.id);
216 } 215 }
217 216
218 } // namespace offline_pages 217 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/downloads/download_ui_adapter.h ('k') | components/offline_pages/offline_page_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698