Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Add comment per feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_model_impl_unittest.cc b/components/offline_pages/offline_page_model_impl_unittest.cc
index f38fe3f90f61b554aa7849d86b18926aa6482032..d28c87c463fd14e93edd597a0efaa895e38d5737 100644
--- a/components/offline_pages/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/offline_page_model_impl_unittest.cc
@@ -139,9 +139,7 @@ class OfflinePageModelImplTest
const OfflinePageItem* GetPageByOfflineId(int64_t offline_id);
- MultipleOfflinePageItemResult GetPagesByOnlineURL(const GURL& offline_url);
-
- const OfflinePageItem* GetPageByOfflineURL(const GURL& offline_url);
+ MultipleOfflinePageItemResult GetPagesByOnlineURL(const GURL& online_url);
OfflinePageModelImpl* model() { return model_.get(); }
@@ -366,17 +364,6 @@ const OfflinePageItem* OfflinePageModelImplTest::GetPageByOfflineId(
return result;
}
-const OfflinePageItem* OfflinePageModelImplTest::GetPageByOfflineURL(
- const GURL& offline_url) {
- const OfflinePageItem* result = nullptr;
- model()->GetPageByOfflineURL(
- offline_url,
- base::Bind(&OfflinePageModelImplTest::OnGetSingleOfflinePageItemResult,
- AsWeakPtr(), base::Unretained(&result)));
- PumpLoop();
- return result;
-}
-
void OfflinePageModelImplTest::OnGetSingleOfflinePageItemResult(
const OfflinePageItem** storage,
const OfflinePageItem* result) {
@@ -885,34 +872,6 @@ TEST_F(OfflinePageModelImplTest, GetPageByOfflineId) {
EXPECT_FALSE(page);
}
-TEST_F(OfflinePageModelImplTest, GetPageByOfflineURL) {
- SavePage(kTestUrl, kTestClientId1);
- int64_t offline1 = last_save_offline_id();
-
- OfflinePageTestStore* store = GetStore();
- GURL offline_url = store->last_saved_page().GetOfflineURL();
-
- SavePage(kTestUrl2, kTestClientId2);
-
- GURL offline_url2 = store->last_saved_page().GetOfflineURL();
- int64_t offline2 = last_save_offline_id();
-
- const OfflinePageItem* page = GetPageByOfflineURL(offline_url2);
- EXPECT_TRUE(page);
- EXPECT_EQ(kTestUrl2, page->url);
- EXPECT_EQ(kTestClientId2, page->client_id);
- EXPECT_EQ(offline2, page->offline_id);
-
- page = GetPageByOfflineURL(offline_url);
- EXPECT_TRUE(page);
- EXPECT_EQ(kTestUrl, page->url);
- EXPECT_EQ(kTestClientId1, page->client_id);
- EXPECT_EQ(offline1, page->offline_id);
-
- page = GetPageByOfflineURL(GURL("http://foo"));
- EXPECT_FALSE(page);
-}
-
TEST_F(OfflinePageModelImplTest, GetPagesByOnlineURL) {
SavePage(kTestUrl, kTestClientId1);
SavePage(kTestUrl2, kTestClientId2);
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/stub_offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698