Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3480)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Add comment per feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 0353f0c068e14dd97996dcda1f5b52ebfd1ac96a..acf3559a026ef34b51393cb78933b40af4807620 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -1036,8 +1036,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
final Activity mainActivity = this;
WebContents webContents = currentTab.getWebContents();
- boolean isOfflinePage = currentTab.isOfflinePage();
- RecordHistogram.recordBooleanHistogram("OfflinePages.SharedPageWasOffline", isOfflinePage);
+ RecordHistogram.recordBooleanHistogram(
+ "OfflinePages.SharedPageWasOffline", currentTab.isOfflinePage());
boolean canShareOfflinePage = OfflinePageBridge.isPageSharingEnabled();
// Share an empty blockingUri in place of screenshot file. The file ready notification is
@@ -1047,7 +1047,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
: ChromeFileProvider.generateUriAndBlockAccess(mainActivity);
if (canShareOfflinePage) {
OfflinePageUtils.shareOfflinePage(shareDirectly, true, mainActivity, null,
- currentTab.getUrl(), blockingUri, null, currentTab, isOfflinePage);
+ blockingUri, null, currentTab);
} else {
ShareHelper.share(shareDirectly, true, mainActivity, currentTab.getTitle(), null,
currentTab.getUrl(), null, blockingUri, null);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698