Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2948)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Add comment per feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index 11ee29d0120c857abb4706fdbc3abec78a255f30..9e17f3c2be99f313a8d15ca548294977de83d4d4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -309,17 +309,6 @@ public class OfflinePageBridge {
}
/**
- * Get the offline page associated with the provided offline URL.
- *
- * @param offlineUrl URL pointing to the offline copy of the web page.
- * @param callback callback to pass back the
- * matching {@link OfflinePageItem} if found. Will pass back <code>null</code> if not.
- */
- public void getPageByOfflineUrl(String offlineUrl, Callback<OfflinePageItem> callback) {
- nativeGetPageByOfflineUrl(mNativeOfflinePageBridge, offlineUrl, callback);
- }
-
- /**
* Get the offline page associated with the provided offline ID.
*
* @param offlineId ID of the offline page.
@@ -548,18 +537,17 @@ public class OfflinePageBridge {
@CalledByNative
private static void createOfflinePageAndAddToList(List<OfflinePageItem> offlinePagesList,
- String url, long offlineId, String clientNamespace, String clientId, String offlineUrl,
- String filePath, long fileSize, long creationTime, int accessCount,
- long lastAccessTimeMs) {
+ String url, long offlineId, String clientNamespace, String clientId, String filePath,
+ long fileSize, long creationTime, int accessCount, long lastAccessTimeMs) {
offlinePagesList.add(createOfflinePageItem(url, offlineId, clientNamespace, clientId,
- offlineUrl, filePath, fileSize, creationTime, accessCount, lastAccessTimeMs));
+ filePath, fileSize, creationTime, accessCount, lastAccessTimeMs));
}
@CalledByNative
private static OfflinePageItem createOfflinePageItem(String url, long offlineId,
- String clientNamespace, String clientId, String offlineUrl, String filePath,
- long fileSize, long creationTime, int accessCount, long lastAccessTimeMs) {
- return new OfflinePageItem(url, offlineId, clientNamespace, clientId, offlineUrl, filePath,
+ String clientNamespace, String clientId, String filePath, long fileSize,
+ long creationTime, int accessCount, long lastAccessTimeMs) {
+ return new OfflinePageItem(url, offlineId, clientNamespace, clientId, filePath,
fileSize, creationTime, accessCount, lastAccessTimeMs);
}
@@ -597,8 +585,6 @@ public class OfflinePageBridge {
private native void nativeSelectPageForOnlineUrl(
long nativeOfflinePageBridge, String onlineUrl, int tabId,
Callback<OfflinePageItem> callback);
- private native void nativeGetPageByOfflineUrl(
- long nativeOfflinePageBridge, String offlineUrl, Callback<OfflinePageItem> callback);
private native void nativeSavePage(long nativeOfflinePageBridge, SavePageCallback callback,
WebContents webContents, String clientNamespace, String clientId);
private native void nativeSavePageLater(long nativeOfflinePageBridge, String url,

Powered by Google App Engine
This is Rietveld 408576698