Add BlimpView to a Chrome tab when Blimp is enabled.

Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsViewAndroid. It is created whenever the
BlimpContentsViewAndroid is created, which is done when
BlimpContentsImpl is created.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

The BlimpView is with this patch attached to the view hierarchy,
and sends onSizeChanged events to the BlimpContentsImpl. The
touch events are piped through to the BlimpCompositorManager.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
Committed: https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb
Cr-Commit-Position: refs/heads/master@{#415760}

[nyquist, 2016-08-24 23:38:10]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[nyquist, 2016-08-24 23:38:21]

nyquist@chromium.org changed reviewers:
+ dtrainor@chromium.org

[nyquist, 2016-08-24 23:38:21]

dtrainor: PTAL

[commit-bot: I haz the power, 2016-08-24 23:39:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:53:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[David Trainor- moved to gerrit, 2016-08-26 19:39:46]

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/android/b...
File blimp/client/core/android/blimp_client_context_impl_android.cc (right):

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/android/b...
blimp/client/core/android/blimp_client_context_impl_android.cc:65:
BlimpClientContextImplAndroid::CreateBlimpContents() {
Have this take a ui::NativeWindow?  Then you can cast it to WindowAndroid and
make magic happen for that context :D.

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/contents/...
File blimp/client/core/contents/android/blimp_contents_impl_android.h (right):

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/contents/...
blimp/client/core/contents/android/blimp_contents_impl_android.h:27: //
Iniitalizes the Java class with the current BlimpContextDelegate.
BlimpClientContextDelegate?

[nyquist, 2016-08-27 01:50:42]

dtrainor: PTAL

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/android/b...
File blimp/client/core/android/blimp_client_context_impl_android.cc (right):

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/android/b...
blimp/client/core/android/blimp_client_context_impl_android.cc:65:
BlimpClientContextImplAndroid::CreateBlimpContents() {
On 2016/08/26 19:39:46, David Trainor wrote:
> Have this take a ui::NativeWindow?  Then you can cast it to WindowAndroid and
> make magic happen for that context :D.

Magic now happens.

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/contents/...
File blimp/client/core/contents/android/blimp_contents_impl_android.h (right):

https://codereview.chromium.org/2270323004/diff/1/blimp/client/core/contents/...
blimp/client/core/contents/android/blimp_contents_impl_android.h:27: //
Iniitalizes the Java class with the current BlimpContextDelegate.
On 2016/08/26 19:39:46, David Trainor wrote:
> BlimpClientContextDelegate?

Removed.

[nyquist, 2016-08-27 01:54:22]

Description was changed from

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsImplAndroid. It is created whenever a BlimpContents
is created on the Android platform.

The BlimpView needs access to the current android Context, which
is now provided by the BlimpClientContextDelegate.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

There is no logic as of yet in the BlimpView at all, it is just
attached to the view hierarchy. It will later contain touch
handling code.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
==========

to

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsImplAndroid. It is created whenever the
BlimpContentsImplAndroid is created, which is done lazily from the
BlimpContentsImpl.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

There is no logic as of yet in the BlimpView at all, it is just
attached to the view hierarchy. It will later contain touch
handling code.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
==========

[Khushal, 2016-08-27 01:55:21]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 01:55:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 02:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 02:47:23]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[David Trainor- moved to gerrit, 2016-08-29 05:29:34]

some creation flow questions, but looking good otherwise!

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/DEPS
File blimp/client/core/DEPS (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/DEPS#...
blimp/client/core/DEPS:2: "+ui/android",
Aren't core deps much larger than just ui/android?  I think khushalsagar@ is
moving ui/android to a non-"to-be-removed" dep in blimp/client, so you should be
ok without this IIUC.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_contents_impl_android.cc (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_contents_impl_android.cc:52:
Java_BlimpContentsImpl_setBlimpView(base::android::AttachCurrentThread(),
Is there a way to clean this up?  Maybe build the BlimpView in java and have
that pass the BlimpContents in as it creates it and pass that down to native in
a nativeInit() method?  Not 100% sure what the cleanest way to do this is
though!

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_contents_impl_android.h (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_contents_impl_android.h:37:
std::unique_ptr<BlimpView> blimp_view_;
Add a TODO to investigate moving this to the BlimpContentsView if that makes
more sense.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_view.h (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:17: // The JNI bridge for the
Java BlimpView that will visually represent the Blimp
Can you explain that native creates the java side here?

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:21: BlimpView(JNIEnv* env,
Should we just pull env internally?

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:23: jobject
jblimp_contents_impl);
Can we just store this natively and have Java just always delegate to native
when we have to talk to the BlimpContents?  The only times I can see this
happening for now are onSizeChanged() and onTouchEvent(), both of which will
marshal to native here and will hit the BlimpContents in native only.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java
(right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java:48:
// TODO(nyquist): Pipe to TabControlFeature.
also onTouchEvent! :)

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/public/and...
File
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
(right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/public/and...
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java:24:
BlimpContents createBlimpContents(WindowAndroid windowAndroid);
@param?

[nyquist, 2016-08-29 19:09:20]

dtrainor: PTAL

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/DEPS
File blimp/client/core/DEPS (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/DEPS#...
blimp/client/core/DEPS:2: "+ui/android",
On 2016/08/29 05:29:33, David Trainor wrote:
> Aren't core deps much larger than just ui/android?  I think khushalsagar@ is
> moving ui/android to a non-"to-be-removed" dep in blimp/client, so you should
be
> ok without this IIUC.

Yeah, it was just to get the checks working. Most of the DEPS was already in
//blimp/client, so I just moved it in here, since I needed it two places. Happy
to remove / move whatever as soon as I rebase on top of khushalsagar@s change.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_contents_impl_android.cc (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_contents_impl_android.cc:52:
Java_BlimpContentsImpl_setBlimpView(base::android::AttachCurrentThread(),
On 2016/08/29 05:29:33, David Trainor wrote:
> Is there a way to clean this up?  Maybe build the BlimpView in java and have
> that pass the BlimpContents in as it creates it and pass that down to native
in
> a nativeInit() method?  Not 100% sure what the cleanest way to do this is
> though!

Well, passing it in to the constructor is clean, no? So I'm doing that now :-)

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_contents_impl_android.h (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_contents_impl_android.h:37:
std::unique_ptr<BlimpView> blimp_view_;
On 2016/08/29 05:29:33, David Trainor wrote:
> Add a TODO to investigate moving this to the BlimpContentsView if that makes
> more sense.

Done.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_view.h (right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:17: // The JNI bridge for the
Java BlimpView that will visually represent the Blimp
On 2016/08/29 05:29:33, David Trainor wrote:
> Can you explain that native creates the java side here?

Done.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:21: BlimpView(JNIEnv* env,
On 2016/08/29 05:29:33, David Trainor wrote:
> Should we just pull env internally?

Done.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:23: jobject
jblimp_contents_impl);
On 2016/08/29 05:29:33, David Trainor wrote:
> Can we just store this natively and have Java just always delegate to native
> when we have to talk to the BlimpContents?  The only times I can see this
> happening for now are onSizeChanged() and onTouchEvent(), both of which will
> marshal to native here and will hit the BlimpContents in native only.

Wow, that had a lot of nice consequences!

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
File
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java
(right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/core/conte...
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java:48:
// TODO(nyquist): Pipe to TabControlFeature.
On 2016/08/29 05:29:33, David Trainor wrote:
> also onTouchEvent! :)

Done.

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/public/and...
File
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
(right):

https://codereview.chromium.org/2270323004/diff/40001/blimp/client/public/and...
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java:24:
BlimpContents createBlimpContents(WindowAndroid windowAndroid);
On 2016/08/29 05:29:33, David Trainor wrote:
> @param?

Done.

[nyquist, 2016-08-29 19:09:30]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 19:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:30:07]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[nyquist, 2016-08-30 20:21:54]

dtrainor: PTAL based on offline discussions

[nyquist, 2016-08-30 20:24:22]

Description was changed from

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsImplAndroid. It is created whenever the
BlimpContentsImplAndroid is created, which is done lazily from the
BlimpContentsImpl.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

There is no logic as of yet in the BlimpView at all, it is just
attached to the view hierarchy. It will later contain touch
handling code.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
==========

to

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsViewAndroid. It is created whenever the
BlimpContentsViewAndroid is created, which is done when
BlimpContentsImpl is created.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

The BlimpView is with this patch attached to the view hierarchy,
and sends onSizeChanged events to the BlimpContentsImpl. The
OnTouchEvent code is there, but it currently is not sent anywhere.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
==========

[David Trainor- moved to gerrit, 2016-08-30 21:14:06]

lgtm % nits thanks!

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/andro...
File blimp/client/core/android/blimp_client_context_impl_android.cc (right):

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/andro...
blimp/client/core/android/blimp_client_context_impl_android.cc:72:
BlimpClientContextImpl::CreateBlimpContents(window_android);
Remove BlimpClientContextImpl::

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_view.h (right):

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:18: // The JNI bridge for the
Java BlimpView that will visually represent the Blimp
it doesn't actually visually represent the content, but it gives hooks to the
Android framework to interact with the rendered content.

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
File
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java
(right):

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java:53:
// View overrides.
Move this up above onSizeChanged.

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java:58:
// TODO(shaktisahu): Close the IME if it is open and if it was, immediately
return.
Just use dialog.setCanceledOnTouchOutside(true);?  Also commented on the bug.

https://codereview.chromium.org/2270323004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
(right):

https://codereview.chromium.org/2270323004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java:39:
if (isShowing(viewToShow)) return;
Hmm should we pull "if (isShowing(viewToShow)) return;" out of the
if/elseif/else blocks?

[nyquist, 2016-08-30 21:50:42]

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/andro...
File blimp/client/core/android/blimp_client_context_impl_android.cc (right):

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/andro...
blimp/client/core/android/blimp_client_context_impl_android.cc:72:
BlimpClientContextImpl::CreateBlimpContents(window_android);
On 2016/08/30 21:14:06, David Trainor wrote:
> Remove BlimpClientContextImpl::

Done.

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
File blimp/client/core/contents/android/blimp_view.h (right):

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
blimp/client/core/contents/android/blimp_view.h:18: // The JNI bridge for the
Java BlimpView that will visually represent the Blimp
On 2016/08/30 21:14:06, David Trainor wrote:
> it doesn't actually visually represent the content, but it gives hooks to the
> Android framework to interact with the rendered content.

Done. Thanks!

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
File
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java
(right):

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java:53:
// View overrides.
On 2016/08/30 21:14:06, David Trainor wrote:
> Move this up above onSizeChanged.

Done.

https://codereview.chromium.org/2270323004/diff/80001/blimp/client/core/conte...
blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java:58:
// TODO(shaktisahu): Close the IME if it is open and if it was, immediately
return.
On 2016/08/30 21:14:06, David Trainor wrote:
> Just use dialog.setCanceledOnTouchOutside(true);?  Also commented on the bug.

Great! I'll remove this comment then, as it's not helpful.

https://codereview.chromium.org/2270323004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
(right):

https://codereview.chromium.org/2270323004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java:39:
if (isShowing(viewToShow)) return;
On 2016/08/30 21:14:06, David Trainor wrote:
> Hmm should we pull "if (isShowing(viewToShow)) return;" out of the
> if/elseif/else blocks?

Agreed. Done. Also extracted into its own helper method now that the return is
on the outside.

[nyquist, 2016-08-30 22:20:05]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-08-30 22:20:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2270323004/#ps120001
(title: "Rebased on top of origin/master for good measure.")

[commit-bot: I haz the power, 2016-08-30 22:20:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 23:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:53:00]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nyquist, 2016-08-31 16:38:33]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 16:38:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 16:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 16:41:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nyquist, 2016-08-31 17:39:30]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:40:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2016-08-31 17:40:11]

nyquist@chromium.org changed reviewers:
+ tedchoc@chromium.org

[nyquist, 2016-08-31 17:40:12]

tedchoc: PTAL //ui/android

[commit-bot: I haz the power, 2016-08-31 18:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 18:38:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nyquist, 2016-08-31 19:16:22]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 19:16:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2016-08-31 19:28:05]

ui - lgtm

https://codereview.chromium.org/2270323004/diff/180001/ui/android/java/src/or...
File ui/android/java/src/org/chromium/ui/base/WindowAndroid.java (right):

https://codereview.chromium.org/2270323004/diff/180001/ui/android/java/src/or...
ui/android/java/src/org/chromium/ui/base/WindowAndroid.java:511:
mNativeWindowAndroid = 0;
since this gets cleared by the destructor natively, I think we should remove
this line.

[nyquist, 2016-08-31 20:05:46]

Description was changed from

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsViewAndroid. It is created whenever the
BlimpContentsViewAndroid is created, which is done when
BlimpContentsImpl is created.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

The BlimpView is with this patch attached to the view hierarchy,
and sends onSizeChanged events to the BlimpContentsImpl. The
OnTouchEvent code is there, but it currently is not sent anywhere.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
==========

to

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsViewAndroid. It is created whenever the
BlimpContentsViewAndroid is created, which is done when
BlimpContentsImpl is created.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

The BlimpView is with this patch attached to the view hierarchy,
and sends onSizeChanged events to the BlimpContentsImpl. The
touch events are piped through to the BlimpCompositorManager.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
==========

[nyquist, 2016-08-31 20:06:11]

All done!

https://codereview.chromium.org/2270323004/diff/180001/ui/android/java/src/or...
File ui/android/java/src/org/chromium/ui/base/WindowAndroid.java (right):

https://codereview.chromium.org/2270323004/diff/180001/ui/android/java/src/or...
ui/android/java/src/org/chromium/ui/base/WindowAndroid.java:511:
mNativeWindowAndroid = 0;
On 2016/08/31 19:28:05, Ted C wrote:
> since this gets cleared by the destructor natively, I think we should remove
> this line.

Done.

[nyquist, 2016-08-31 20:06:19]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-08-31 20:06:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2270323004/#ps200001
(title: "addressed nit, renamed CreateForTesting and piped through touch
handling")

[commit-bot: I haz the power, 2016-08-31 20:06:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:28:30]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-08-31 21:31:47]

Description was changed from

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsViewAndroid. It is created whenever the
BlimpContentsViewAndroid is created, which is done when
BlimpContentsImpl is created.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

The BlimpView is with this patch attached to the view hierarchy,
and sends onSizeChanged events to the BlimpContentsImpl. The
touch events are piped through to the BlimpCompositorManager.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759
==========

to

==========
Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsViewAndroid. It is created whenever the
BlimpContentsViewAndroid is created, which is done when
BlimpContentsImpl is created.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

The BlimpView is with this patch attached to the view hierarchy,
and sends onSizeChanged events to the BlimpContentsImpl. The
touch events are piped through to the BlimpCompositorManager.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG=608759

Committed: https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb
Cr-Commit-Position: refs/heads/master@{#415760}
==========

[commit-bot: I haz the power, 2016-08-31 21:31:49]

Patchset 11 (id:??) landed as
https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb
Cr-Commit-Position: refs/heads/master@{#415760}