Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: blimp/client/core/contents/android/blimp_view.h

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)
Patch Set: Magic now happens Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef BLIMP_CLIENT_CORE_CONTENTS_ANDROID_BLIMP_VIEW_H_
6 #define BLIMP_CLIENT_CORE_CONTENTS_ANDROID_BLIMP_VIEW_H_
7
8 #include <jni.h>
9
10 #include "base/android/jni_android.h"
11 #include "base/android/scoped_java_ref.h"
12 #include "ui/android/window_android.h"
13
14 namespace blimp {
15 namespace client {
16
17 // The JNI bridge for the Java BlimpView that will visually represent the Blimp
David Trainor- moved to gerrit 2016/08/29 05:29:33 Can you explain that native creates the java side
nyquist 2016/08/29 19:09:19 Done.
18 // rendered content.
19 class BlimpView {
20 public:
21 BlimpView(JNIEnv* env,
David Trainor- moved to gerrit 2016/08/29 05:29:33 Should we just pull env internally?
nyquist 2016/08/29 19:09:19 Done.
22 ui::WindowAndroid* window,
23 jobject jblimp_contents_impl);
David Trainor- moved to gerrit 2016/08/29 05:29:33 Can we just store this natively and have Java just
nyquist 2016/08/29 19:09:19 Wow, that had a lot of nice consequences!
24 ~BlimpView();
25
26 base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
27
28 private:
29 base::android::ScopedJavaGlobalRef<jobject> java_obj_;
30
31 DISALLOW_COPY_AND_ASSIGN(BlimpView);
32 };
33
34 } // namespace client
35 } // namespace blimp
36
37 #endif // BLIMP_CLIENT_CORE_CONTENTS_ANDROID_BLIMP_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698