Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: blimp/client/public/blimp_client_context.h

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)
Patch Set: addressed nit, renamed CreateForTesting and piped through touch handling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/public/blimp_client_context.h
diff --git a/blimp/client/public/blimp_client_context.h b/blimp/client/public/blimp_client_context.h
index 908aaca6238becc0ccefbde8b6a105f1dd23579f..bc4424ce8b48d08fa7fbbd5f64499c9bba228d23 100644
--- a/blimp/client/public/blimp_client_context.h
+++ b/blimp/client/public/blimp_client_context.h
@@ -13,6 +13,7 @@
#include "blimp/client/public/blimp_client_context_delegate.h"
#include "blimp/client/public/contents/blimp_contents.h"
#include "components/keyed_service/core/keyed_service.h"
+#include "ui/gfx/native_widget_types.h"
#if defined(OS_ANDROID)
#include "base/android/jni_android.h"
@@ -56,10 +57,11 @@ class BlimpClientContext : public KeyedService {
// The delegate provides all the required functionality from the embedder.
virtual void SetDelegate(BlimpClientContextDelegate* delegate) = 0;
- // Creates a new BlimpContents.
+ // Creates a new BlimpContents that will be shown in |window|.
// TODO(mlliu): Currently we want to have a single BlimpContents. If there is
// an existing contents, return nullptr (http://crbug.com/642558).
- virtual std::unique_ptr<BlimpContents> CreateBlimpContents() = 0;
+ virtual std::unique_ptr<BlimpContents> CreateBlimpContents(
+ gfx::NativeWindow window) = 0;
// Start authentication flow and connection to engine.
virtual void Connect() = 0;
« no previous file with comments | « blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java ('k') | blimp/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698