blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java - Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)

Patch Set: addressed nit, renamed CreateForTesting and piped through touch handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java ('k') | blimp/client/public/blimp_client_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java

diff --git a/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java b/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java

index 9ef13580e4cd84682c683c1474040710192a7421..e961b46bebab4436563852c7156e5a938eff5729 100644

--- a/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java

+++ b/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java

@@ -4,6 +4,8 @@

package org.chromium.blimp_public.contents;

+import android.view.ViewGroup;

/**

* BlimpContents is the Java representation of a native BlimpContents object.

@@ -29,6 +31,11 @@ public interface BlimpContents {

void removeObserver(BlimpContentsObserver observer);

/**

+ * Returns a view that represents the content for this BlimpContents.

+ */

+ ViewGroup getView();

+ /**

* For BlimpContents that are owned by Java, this must be called before this BlimpContents is

* garbage collected.