blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java - Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)

Patch Set: addressed nit, renamed CreateForTesting and piped through touch handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/public/BUILD.gn ('k') | blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

diff --git a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

index 21ef6729273608f8e0cd82f6ec74f9ac273c0015..cab3cd5327199b90faf8d9d7d366278cde49fd99 100644

--- a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

+++ b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

@@ -7,6 +7,7 @@ package org.chromium.blimp_public;

import android.preference.PreferenceFragment;

import org.chromium.blimp_public.contents.BlimpContents;

+import org.chromium.ui.base.WindowAndroid;

/**

* BlimpClientContext is the Java representation of a native BlimpClientContext object.

@@ -19,8 +20,9 @@ public interface BlimpClientContext {

/**

* Creates a {@link BlimpContents} and takes ownership of it. The caller must call

* {@link BlimpContents#destroy()} for destruction of the BlimpContents.

+ * @param windowAndroid the window this BlimpContents will be displayed in.

- BlimpContents createBlimpContents();

+ BlimpContents createBlimpContents(WindowAndroid windowAndroid);

/**

* @return If Blimp is supported with this build.