Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: ui/android/java/src/org/chromium/ui/base/WindowAndroid.java

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)
Patch Set: addressed nit, renamed CreateForTesting and piped through touch handling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | ui/android/resources/resource_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
diff --git a/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java b/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
index cceb825154168f1b0c5147f5071e051f52999781..dabb468983aa8e19a23b3e5ce859786048a0485c 100644
--- a/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
+++ b/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
@@ -182,6 +182,11 @@ public class WindowAndroid {
return new WindowAndroid(context);
}
+ @CalledByNative
+ private void clearNativePointer() {
+ mNativeWindowAndroid = 0;
+ }
+
/**
* Set the delegate that will handle android permissions requests.
*/
@@ -502,8 +507,8 @@ public class WindowAndroid {
*/
public void destroy() {
if (mNativeWindowAndroid != 0) {
+ // Native code clears |mNativeWindowAndroid|.
nativeDestroy(mNativeWindowAndroid);
- mNativeWindowAndroid = 0;
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | ui/android/resources/resource_manager_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698