blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java - Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)

Patch Set: addressed nit, renamed CreateForTesting and piped through touch handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java ('k') | blimp/client/core/blimp_client_context_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

diff --git a/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java b/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

index cff5df6d60f2b196f795504fa3f0ce3cb04cf6a5..c49dd700e2325d0f9d44f12b014057e091ce28c0 100644

--- a/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

+++ b/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

@@ -11,6 +11,7 @@ import org.chromium.base.annotations.JNINamespace;

import org.chromium.blimp_public.BlimpClientContext;

import org.chromium.blimp_public.BlimpClientContextDelegate;

import org.chromium.blimp_public.contents.BlimpContents;

+import org.chromium.ui.base.WindowAndroid;

/**

* A dummy implementation of the {@link BlimpClientContext}.

@@ -32,7 +33,7 @@ public class DummyBlimpClientContext implements BlimpClientContext {

}

@Override

- public BlimpContents createBlimpContents() {

+ public BlimpContents createBlimpContents(WindowAndroid windowAndroid) {

return null;

}