blimp/client/core/DEPS - Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/core/DEPS

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)

Patch Set: Magic now happens Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+device/hid"	2 "+ui/android",
	David Trainor- moved to gerrit 2016/08/29 05:29:33 Aren't core deps much larger than just ui/android? Aren't core deps much larger than just ui/android? I think khushalsagar@ is moving ui/android to a non-"to-be-removed" dep in blimp/client, so you should be ok without this IIUC. nyquist 2016/08/29 19:09:19 Yeah, it was just to get the checks working. Most Show quoted text On 2016/08/29 05:29:33, David Trainor wrote: > Aren't core deps much larger than just ui/android? I think khushalsagar@ is > moving ui/android to a non-"to-be-removed" dep in blimp/client, so you should be > ok without this IIUC. Yeah, it was just to get the checks working. Most of the DEPS was already in //blimp/client, so I just moved it in here, since I needed it two places. Happy to remove / move whatever as soon as I rebase on top of khushalsagar@s change.
3 ]	3 ]

OLD	NEW