blimp/client/core/android/blimp_client_context_impl_android.h - Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/blimp_client_context_impl_android.h

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)

Patch Set: addressed nit, renamed CreateForTesting and piped through touch handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/android/blimp_client_context_impl_android.h

diff --git a/blimp/client/core/android/blimp_client_context_impl_android.h b/blimp/client/core/android/blimp_client_context_impl_android.h

index b8c3e1e278884b90c956a3060067a8c89985b58c..c0e665380e6e0b520672dae788524f6a2acf7130 100644

--- a/blimp/client/core/android/blimp_client_context_impl_android.h

+++ b/blimp/client/core/android/blimp_client_context_impl_android.h

@@ -33,9 +33,8 @@ class BlimpClientContextImplAndroid : public BlimpClientContextImpl {

base::android::ScopedJavaLocalRef<jobject> GetJavaObject();

- base::android::ScopedJavaLocalRef<jobject> CreateBlimpContentsJava(

- JNIEnv* env,

- jobject jobj);

+ base::android::ScopedJavaLocalRef<jobject>

+ CreateBlimpContentsJava(JNIEnv* env, jobject jobj, jlong window_android_ptr);

// Start authentication flow from Java.

void ConnectFromJava(JNIEnv* env, jobject jobj);