mash: Convert ShelfView to wm common types, clean up Shelf access

mash: Convert ShelfView to wm common types, clean up Shelf access

* Eliminate aura::Window from ShelfView
* Eliminate Shelf access from ShelfView in favor of WmShelf
* Remove some ash::Shell usage in ShelfView unit tests
* Move IsHorizontalAlignment, SelectValueForAlignment and PrimaryAxisValue
from Shelf to WmShelf and make them not templates
* Move files to //ash/common/shelf

BUG=635638
TEST=ash_unittests, unit_tests

Committed: https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493
Cr-Commit-Position: refs/heads/master@{#410512}

[James Cook, 2016-08-08 22:58:19]

Description was changed from

==========
mash: Convert ShelfView to wm common types, clean up Shelf access

* Eliminate aura::Window from ShelfView
* Eliminate Shelf access from ShelfView in favor of WmShelf
* Remove some ash::Shell usage in ShelfView unit tests
* Move IsHorizontalAlignment, SelectValueForAlignment and PrimaryAxisValue
from Shelf to WmShelf and make them not templates

BUG=635638
TEST=ash_unittests, unit_tests
==========

to

==========
mash: Convert ShelfView to wm common types, clean up Shelf access

* Eliminate aura::Window from ShelfView
* Eliminate Shelf access from ShelfView in favor of WmShelf
* Remove some ash::Shell usage in ShelfView unit tests
* Move IsHorizontalAlignment, SelectValueForAlignment and PrimaryAxisValue
from Shelf to WmShelf and make them not templates
* Move files to //ash/common/shelf

BUG=635638
TEST=ash_unittests, unit_tests
==========

[James Cook, 2016-08-08 23:07:58]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:08:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-08 23:08:39]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-08 23:08:40]

msw, please take a look.

This went a little further than just eliminating aura from ShelfView, but I
think converting things from Shelf to WmShelf will be useful in the long run.

[commit-bot: I haz the power, 2016-08-08 23:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:23:31]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[msw, 2016-08-08 23:29:48]

Very nice! lgtm

[James Cook, 2016-08-08 23:36:10]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-08 23:36:10]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2228713003/#ps60001
(title: "fix control reaches end of non-void function warnings")

[commit-bot: I haz the power, 2016-08-08 23:36:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 00:21:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-09 00:23:14]

Description was changed from

==========
mash: Convert ShelfView to wm common types, clean up Shelf access

* Eliminate aura::Window from ShelfView
* Eliminate Shelf access from ShelfView in favor of WmShelf
* Remove some ash::Shell usage in ShelfView unit tests
* Move IsHorizontalAlignment, SelectValueForAlignment and PrimaryAxisValue
from Shelf to WmShelf and make them not templates
* Move files to //ash/common/shelf

BUG=635638
TEST=ash_unittests, unit_tests
==========

to

==========
mash: Convert ShelfView to wm common types, clean up Shelf access

* Eliminate aura::Window from ShelfView
* Eliminate Shelf access from ShelfView in favor of WmShelf
* Remove some ash::Shell usage in ShelfView unit tests
* Move IsHorizontalAlignment, SelectValueForAlignment and PrimaryAxisValue
from Shelf to WmShelf and make them not templates
* Move files to //ash/common/shelf

BUG=635638
TEST=ash_unittests, unit_tests

Committed: https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493
Cr-Commit-Position: refs/heads/master@{#410512}
==========

[commit-bot: I haz the power, 2016-08-09 00:23:15]

Patchset 4 (id:??) landed as
https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493
Cr-Commit-Position: refs/heads/master@{#410512}