Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: ash/shelf/shelf.cc

Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix control reaches end of non-void function warnings Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf.h ('k') | ash/shelf/shelf_icon_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf.cc
diff --git a/ash/shelf/shelf.cc b/ash/shelf/shelf.cc
index 74db518ded0b161c94febc3072c5e1597a44bf0b..d519ef1a80ea40665e0ef9602a865350a617dda6 100644
--- a/ash/shelf/shelf.cc
+++ b/ash/shelf/shelf.cc
@@ -12,14 +12,13 @@
#include "ash/common/shelf/shelf_item_delegate.h"
#include "ash/common/shelf/shelf_model.h"
#include "ash/common/shelf/shelf_navigator.h"
-#include "ash/common/shelf/wm_shelf_util.h"
+#include "ash/common/shelf/shelf_view.h"
#include "ash/common/shell_window_ids.h"
#include "ash/common/wm_shell.h"
#include "ash/root_window_controller.h"
#include "ash/screen_util.h"
#include "ash/shelf/shelf_layout_manager.h"
#include "ash/shelf/shelf_util.h"
-#include "ash/shelf/shelf_view.h"
#include "ash/shell.h"
#include "ash/wm/window_properties.h"
#include "ui/aura/window.h"
@@ -47,7 +46,7 @@ Shelf::Shelf(ShelfModel* shelf_model,
shelf_view_(new ShelfView(shelf_model,
WmShell::Get()->shelf_delegate(),
wm_shelf,
- this)),
+ shelf_widget)),
shelf_locking_manager_(wm_shelf) {
DCHECK(wm_shelf_);
shelf_view_->Init();
@@ -90,10 +89,6 @@ void Shelf::SetAlignment(ShelfAlignment alignment) {
// ShelfLayoutManager will resize the shelf.
}
-bool Shelf::IsHorizontalAlignment() const {
- return ::ash::IsHorizontalAlignment(alignment_);
-}
-
void Shelf::SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide_behavior) {
if (auto_hide_behavior_ == auto_hide_behavior)
return;
« no previous file with comments | « ash/shelf/shelf.h ('k') | ash/shelf/shelf_icon_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698