ash/common/shelf/overflow_bubble.cc - Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/shelf/overflow_bubble.cc

Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix control reaches end of non-void function warnings Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/common/shelf/overflow_bubble.h"	5 #include "ash/common/shelf/overflow_bubble.h"

6	6

7 #include "ash/common/shelf/overflow_bubble_view.h"	7 #include "ash/common/shelf/overflow_bubble_view.h"

	8 #include "ash/common/shelf/shelf_view.h"

8 #include "ash/common/shelf/wm_shelf.h"	9 #include "ash/common/shelf/wm_shelf.h"

9 #include "ash/common/system/tray/tray_background_view.h"	10 #include "ash/common/system/tray/tray_background_view.h"

10 #include "ash/common/wm_shell.h"	11 #include "ash/common/wm_shell.h"

11 #include "ash/shelf/shelf_view.h"

12 #include "ui/gfx/geometry/rect.h"	12 #include "ui/gfx/geometry/rect.h"

13 #include "ui/views/widget/widget.h"	13 #include "ui/views/widget/widget.h"

14	14

15 namespace ash {	15 namespace ash {

16	16

17 OverflowBubble::OverflowBubble(WmShelf* wm_shelf)	17 OverflowBubble::OverflowBubble(WmShelf* wm_shelf)

18 : wm_shelf_(wm_shelf),	18 : wm_shelf_(wm_shelf),

19 bubble_(nullptr),	19 bubble_(nullptr),

20 anchor_(nullptr),	20 anchor_(nullptr),

21 shelf_view_(nullptr) {	21 shelf_view_(nullptr) {

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
85	85

86 void OverflowBubble::OnWidgetDestroying(views::Widget* widget) {	86 void OverflowBubble::OnWidgetDestroying(views::Widget* widget) {

87 DCHECK(widget == bubble_->GetWidget());	87 DCHECK(widget == bubble_->GetWidget());

88 bubble_ = NULL;	88 bubble_ = NULL;

89 anchor_ = NULL;	89 anchor_ = NULL;

90 wm_shelf_->SchedulePaint();	90 wm_shelf_->SchedulePaint();

91 shelf_view_ = NULL;	91 shelf_view_ = NULL;

92 }	92 }

93	93

94 } // namespace ash	94 } // namespace ash

OLD	NEW

« no previous file with comments | « ash/common/shelf/app_list_button.cc ('k') | ash/common/shelf/shelf_button.cc » ('j') | no next file with comments »