chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc - Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix control reaches end of non-void function warnings Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

index 7b5ef42bea4af5bb04447db37ed9674f853ba32b..9a4ef82c802a52960f7f1477a7d7985516eb73ea 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

@@ -11,11 +11,11 @@

#include "ash/common/shelf/shelf_button.h"

#include "ash/common/shelf/shelf_constants.h"

#include "ash/common/shelf/shelf_model.h"

+#include "ash/common/shelf/shelf_view.h"

#include "ash/common/wm/window_state.h"

#include "ash/common/wm_shell.h"

#include "ash/shelf/shelf.h"

#include "ash/shelf/shelf_util.h"

-#include "ash/shelf/shelf_view.h"

#include "ash/shell.h"

#include "ash/test/shelf_test_api.h"

#include "ash/test/shelf_view_test_api.h"

« no previous file with comments | « ash/wm/window_animations.cc ('k') | chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc » ('j') | no next file with comments »