ash/common/shelf/wm_shelf_util.h - Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/wm_shelf_util.h

Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix control reaches end of non-void function warnings Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/shelf/wm_shelf_util.h

diff --git a/ash/common/shelf/wm_shelf_util.h b/ash/common/shelf/wm_shelf_util.h

index acda56a267a091f2c89425e8b97af76957c22c2e..2fab27f082b3083c6d704bc7f7af6c4ea9c0c7e5 100644

--- a/ash/common/shelf/wm_shelf_util.h

+++ b/ash/common/shelf/wm_shelf_util.h

@@ -11,6 +11,7 @@

namespace ash {

// Returns true if the shelf |alignment| is horizontal.

+// TODO(jamescook): Remove this in favor of WmShelf::IsHorizontalAlignment().

ASH_EXPORT bool IsHorizontalAlignment(ShelfAlignment alignment);

} // namespace ash

« no previous file with comments | « ash/common/shelf/wm_shelf.cc ('k') | ash/metrics/user_metrics_recorder.cc » ('j') | no next file with comments »