ash/common/shelf/shelf_tooltip_manager.cc - Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_tooltip_manager.cc

Issue 2228713003: mash: Convert ShelfView to wm common types, clean up Shelf access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix control reaches end of non-void function warnings Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/shelf/shelf_tooltip_manager.cc

diff --git a/ash/common/shelf/shelf_tooltip_manager.cc b/ash/common/shelf/shelf_tooltip_manager.cc

index 6a6db00c4a769cd9cf7c1db4193e008412ffab9e..85028953f4e6d3b9f1953e7db6886f1b5cf4316e 100644

--- a/ash/common/shelf/shelf_tooltip_manager.cc

+++ b/ash/common/shelf/shelf_tooltip_manager.cc

@@ -4,13 +4,13 @@

#include "ash/common/shelf/shelf_tooltip_manager.h"

+#include "ash/common/shelf/shelf_view.h"

#include "ash/common/shelf/wm_shelf.h"

#include "ash/common/shell_window_ids.h"

#include "ash/common/wm_lookup.h"

#include "ash/common/wm_root_window_controller.h"

#include "ash/common/wm_shell.h"

#include "ash/common/wm_window.h"

-#include "ash/shelf/shelf_view.h"

#include "base/bind.h"

#include "base/strings/string16.h"

#include "base/threading/thread_task_runner_handle.h"

« no previous file with comments | « ash/common/shelf/shelf_icon_observer.h ('k') | ash/common/shelf/shelf_tooltip_manager_unittest.cc » ('j') | no next file with comments »