Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issue 2220313002: S390: Decouple Add/Sub/Neg to 32/64 Bit Op (Closed)

Created:
4 years, 4 months ago by john.yan
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Decouple Add/Sub/Neg to 32/64 Bit Op 1. Decouple kS390_Add/Sub/Neg to kS390_Add32/Sub32/Neg32/Add64/Sub64/Neg64 2. Nuke kS390_Add/SubWithOverflow32 3. Add Support for Load-On-Condition to optimize AssembleArchBoolean R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/dc88458120e846f7489dc8969e2ed2db12084a6c Cr-Commit-Position: refs/heads/master@{#38443}

Patch Set 1 #

Patch Set 2 : Fix Sub32 too #

Patch Set 3 : Fix Neg32 to use lcr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -312 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 2 6 chunks +38 lines, -136 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 6 chunks +27 lines, -26 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M src/s390/assembler-s390.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/s390/assembler-s390.cc View 3 chunks +34 lines, -1 line 0 comments Download
M src/s390/disasm-s390.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 2 chunks +3 lines, -38 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 5 chunks +21 lines, -88 lines 0 comments Download
M src/s390/simulator-s390.cc View 3 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 4 months ago (2016-08-08 05:08:38 UTC) #1
JaideepBajwa
lgtm
4 years, 4 months ago (2016-08-08 12:45:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220313002/40001
4 years, 4 months ago (2016-08-08 13:38:38 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 14:02:57 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 14:05:18 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc88458120e846f7489dc8969e2ed2db12084a6c
Cr-Commit-Position: refs/heads/master@{#38443}

Powered by Google App Engine
This is Rietveld 408576698