src/compiler/s390/instruction-scheduler-s390.cc - Issue 2220313002: S390: Decouple Add/Sub/Neg to 32/64 Bit Op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/s390/instruction-scheduler-s390.cc

Issue 2220313002: S390: Decouple Add/Sub/Neg to 32/64 Bit Op (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Neg32 to use lcr Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/s390/instruction-scheduler-s390.cc

diff --git a/src/compiler/s390/instruction-scheduler-s390.cc b/src/compiler/s390/instruction-scheduler-s390.cc

index 5ac6da79b2ec7669125d6abf8263550c4534d7d0..dcafbc745a9802190afd767caca085d5995b9703 100644

--- a/src/compiler/s390/instruction-scheduler-s390.cc

+++ b/src/compiler/s390/instruction-scheduler-s390.cc

@@ -36,13 +36,13 @@ int InstructionScheduler::GetTargetInstructionFlags(

case kS390_RotLeftAndClear64:

case kS390_RotLeftAndClearLeft64:

case kS390_RotLeftAndClearRight64:

- case kS390_Add:

- case kS390_AddWithOverflow32:

+ case kS390_Add32:

+ case kS390_Add64:

case kS390_AddPair:

case kS390_AddFloat:

case kS390_AddDouble:

- case kS390_Sub:

- case kS390_SubWithOverflow32:

+ case kS390_Sub32:

+ case kS390_Sub64:

case kS390_SubPair:

case kS390_MulPair:

case kS390_SubFloat:

@@ -65,7 +65,8 @@ int InstructionScheduler::GetTargetInstructionFlags(

case kS390_ModU32:

case kS390_ModU64:

case kS390_ModDouble:

- case kS390_Neg:

+ case kS390_Neg32:

+ case kS390_Neg64:

case kS390_NegDouble:

case kS390_SqrtFloat:

case kS390_FloorFloat: