Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: src/s390/simulator-s390.cc

Issue 2220313002: S390: Decouple Add/Sub/Neg to 32/64 Bit Op (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Neg32 to use lcr Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/s390/macro-assembler-s390.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/s390/simulator-s390.cc
diff --git a/src/s390/simulator-s390.cc b/src/s390/simulator-s390.cc
index 1932d297de91bdaeeae04a3f50022040e4a65a7b..a511fb13aff0d251f0d137732ad8dccee177f993 100644
--- a/src/s390/simulator-s390.cc
+++ b/src/s390/simulator-s390.cc
@@ -5978,6 +5978,12 @@ uintptr_t Simulator::PopAddress() {
int r3 = AS(RRFInstruction)->R3Value(); \
int length = 4;
+#define DECODE_RRF_C_INSTRUCTION(r1, r2, m3) \
+ int r1 = AS(RRFInstruction)->R1Value(); \
+ int r2 = AS(RRFInstruction)->R2Value(); \
+ Condition m3 = static_cast<Condition>(AS(RRFInstruction)->M3Value()); \
+ int length = 4;
+
#define DECODE_RR_INSTRUCTION(r1, r2) \
int r1 = AS(RRInstruction)->R1Value(); \
int r2 = AS(RRInstruction)->R2Value(); \
@@ -10467,9 +10473,12 @@ EVALUATE(POPCNT_Z) {
}
EVALUATE(LOCGR) {
- UNIMPLEMENTED();
- USE(instr);
- return 0;
+ DCHECK_OPCODE(LOCR);
+ DECODE_RRF_C_INSTRUCTION(r1, r2, m3);
+ if (TestConditionCode(m3)) {
+ set_register(r1, get_register(r2));
+ }
+ return length;
}
EVALUATE(NGRK) {
@@ -10564,9 +10573,12 @@ EVALUATE(SLGRK) {
}
EVALUATE(LOCR) {
- UNIMPLEMENTED();
- USE(instr);
- return 0;
+ DCHECK_OPCODE(LOCR);
+ DECODE_RRF_C_INSTRUCTION(r1, r2, m3);
+ if (TestConditionCode(m3)) {
+ set_low_register(r1, get_low_register<int32_t>(r2));
+ }
+ return length;
}
EVALUATE(NRK) {
« no previous file with comments | « src/s390/macro-assembler-s390.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698