Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed)

Created:
4 years, 5 months ago by horo
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tzik, johnme+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, iclelland+watch_chromium.org, jam, chasej+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, harkness+watch_chromium.org, blink-worker-reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, Randy Smith (Not in Mondays), nhiroki, michaeln, serviceworker-reviews, kinuko+serviceworker, pfeldman, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. BUG=616502 Committed: https://crrev.com/36986071183bdb219186aa9f63f9ee4b162d91b9 Committed: https://crrev.com/519e054087b8d7ab72126075040bb7c819c3d007 Cr-Original-Commit-Position: refs/heads/master@{#407487} Cr-Commit-Position: refs/heads/master@{#407761}

Patch Set 1 #

Patch Set 2 : use std::move #

Total comments: 14

Patch Set 3 : fix ServiceWorkerStorage::FindRegistrationForPattern #

Patch Set 4 : incorporated nhiroki's comment #

Patch Set 5 : fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -100 lines) Patch
M content/browser/background_sync/background_sync_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/notifications/notification_event_dispatcher_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/notifications/notification_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_router.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/push_messaging/push_messaging_router.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 1 2 9 chunks +19 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 1 2 3 3 chunks +8 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_unregister_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_unregister_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 42 (25 generated)
horo
nhiroki@ Could you please review?
4 years, 5 months ago (2016-07-25 08:08:18 UTC) #9
nhiroki
https://codereview.chromium.org/2181553003/diff/40001/content/browser/background_sync/background_sync_manager_unittest.cc File content/browser/background_sync/background_sync_manager_unittest.cc (right): https://codereview.chromium.org/2181553003/diff/40001/content/browser/background_sync/background_sync_manager_unittest.cc#newcode71 content/browser/background_sync/background_sync_manager_unittest.cc:71: *out_registration = registration; std::move(registration) https://codereview.chromium.org/2181553003/diff/40001/content/browser/background_sync/background_sync_service_impl_unittest.cc File content/browser/background_sync/background_sync_service_impl_unittest.cc (right): https://codereview.chromium.org/2181553003/diff/40001/content/browser/background_sync/background_sync_service_impl_unittest.cc#newcode56 ...
4 years, 5 months ago (2016-07-25 09:15:40 UTC) #14
horo
https://codereview.chromium.org/2181553003/diff/40001/content/browser/background_sync/background_sync_manager_unittest.cc File content/browser/background_sync/background_sync_manager_unittest.cc (right): https://codereview.chromium.org/2181553003/diff/40001/content/browser/background_sync/background_sync_manager_unittest.cc#newcode71 content/browser/background_sync/background_sync_manager_unittest.cc:71: *out_registration = registration; On 2016/07/25 09:15:40, nhiroki (slow) wrote: ...
4 years, 5 months ago (2016-07-25 09:32:02 UTC) #17
nhiroki
lgtm
4 years, 5 months ago (2016-07-25 09:43:44 UTC) #18
Peter Beverloo
push and notifications lgtm
4 years, 5 months ago (2016-07-25 10:51:02 UTC) #20
horo
jkarlin@: Please review content/browser/background_sync/* dgozman@: Please review content/browser/devtools/* mmenke@: Please review content/browser/loader/*
4 years, 5 months ago (2016-07-25 11:12:45 UTC) #24
jkarlin
content/browser/background_sync* lgtm
4 years, 5 months ago (2016-07-25 11:36:11 UTC) #25
dgozman
devtools lgtm
4 years, 5 months ago (2016-07-25 14:48:49 UTC) #26
mmenke
On 2016/07/25 14:48:49, dgozman wrote: > devtools lgtm content/browser/loader/ LGTM.
4 years, 5 months ago (2016-07-25 15:41:43 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181553003/80001
4 years, 5 months ago (2016-07-25 15:56:14 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 5 months ago (2016-07-25 16:00:42 UTC) #30
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/36986071183bdb219186aa9f63f9ee4b162d91b9 Cr-Commit-Position: refs/heads/master@{#407487}
4 years, 5 months ago (2016-07-25 16:01:40 UTC) #32
dominickn
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.chromium.org/2183783002/ by dominickn@chromium.org. ...
4 years, 5 months ago (2016-07-26 05:35:47 UTC) #33
horo
On 2016/07/26 05:35:47, dominickn wrote: > A revert of this CL (patchset #4 id:80001) has ...
4 years, 4 months ago (2016-07-26 08:35:31 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181553003/100001
4 years, 4 months ago (2016-07-26 08:36:13 UTC) #38
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 4 months ago (2016-07-26 10:43:22 UTC) #40
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 10:45:17 UTC) #42
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/519e054087b8d7ab72126075040bb7c819c3d007
Cr-Commit-Position: refs/heads/master@{#407761}

Powered by Google App Engine
This is Rietveld 408576698