content/browser/devtools/protocol/service_worker_handler.cc - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/service_worker_handler.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_service_impl_unittest.cc ('k') | content/browser/loader/navigation_url_loader_impl_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/service_worker_handler.cc

diff --git a/content/browser/devtools/protocol/service_worker_handler.cc b/content/browser/devtools/protocol/service_worker_handler.cc

index b9f528fdd5bf5d7cc2974b29f6fc683f280ab737..127b0c0a09387da4b8e718713669d4b7a551dbec 100644

--- a/content/browser/devtools/protocol/service_worker_handler.cc

+++ b/content/browser/devtools/protocol/service_worker_handler.cc

@@ -269,7 +269,7 @@ void DidFindRegistrationForDispatchSyncEventOnIO(

const std::string& tag,

bool last_chance,

ServiceWorkerStatusCode status,

- const scoped_refptr<content::ServiceWorkerRegistration>& registration) {

+ scoped_refptr<content::ServiceWorkerRegistration> registration) {

if (status != SERVICE_WORKER_OK || !registration->active_version())

return;

BackgroundSyncManager* background_sync_manager =

@@ -279,7 +279,7 @@ void DidFindRegistrationForDispatchSyncEventOnIO(

// Keep the registration while dispatching the sync event.

background_sync_manager->EmulateDispatchSyncEvent(

tag, std::move(version), last_chance,

- base::Bind(&StatusNoOpKeepingRegistration, registration));

+ base::Bind(&StatusNoOpKeepingRegistration, std::move(registration)));

}

void DispatchSyncEventOnIO(scoped_refptr<ServiceWorkerContextWrapper> context,