Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed)

Created:
4 years, 4 months ago by dominickn
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tzik, johnme+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, iclelland+watch_chromium.org, jam, chasej+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, harkness+watch_chromium.org, blink-worker-reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, Randy Smith (Not in Mondays), nhiroki, michaeln, serviceworker-reviews, kinuko+serviceworker, pfeldman, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (patchset #4 id:80001 of https://codereview.chromium.org/2181553003/ ) Reason for revert: Speculative revert to see if this caused crbug.com/631190. App banners use methods touched by this CL to check if a service worker is registered; this is the only relevant-looking CL in the blamelist for the app banner data fetcher tests starting to fail on the Win7 SP1 bot. This CL will be relanded if re-enabling the disabled app banner data fetcher tests still causes failures on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 Original issue's description: > Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. > > BUG=616502 > > Committed: https://crrev.com/36986071183bdb219186aa9f63f9ee4b162d91b9 > Cr-Commit-Position: refs/heads/master@{#407487} TBR=nhiroki@chromium.org,peter@chromium.org,dgozman@chromium.org,mmenke@chromium.org,jkarlin@chromium.org,horo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616502 Committed: https://crrev.com/0ffd7bda4112522805100efa554bdb7621de860b Cr-Commit-Position: refs/heads/master@{#407715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -95 lines) Patch
M content/browser/background_sync/background_sync_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/notifications/notification_event_dispatcher_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/notifications/notification_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_router.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_router.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 9 chunks +19 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_unregister_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_unregister_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dominickn
Created Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.
4 years, 4 months ago (2016-07-26 05:35:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183783002/1
4 years, 4 months ago (2016-07-26 05:36:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 05:37:17 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 05:39:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ffd7bda4112522805100efa554bdb7621de860b
Cr-Commit-Position: refs/heads/master@{#407715}

Powered by Google App Engine
This is Rietveld 408576698