content/browser/service_worker/service_worker_unregister_job.cc - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_unregister_job.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_unregister_job.h ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_unregister_job.cc

diff --git a/content/browser/service_worker/service_worker_unregister_job.cc b/content/browser/service_worker/service_worker_unregister_job.cc

index c0fc9dc4cb6d528a8ebc37f045a7236fbda54183..0ca2f7f0781c15d061ac31d9ceeff55cb0fa6049 100644

--- a/content/browser/service_worker/service_worker_unregister_job.cc

+++ b/content/browser/service_worker/service_worker_unregister_job.cc

@@ -57,7 +57,7 @@ RegistrationJobType ServiceWorkerUnregisterJob::GetType() const {

void ServiceWorkerUnregisterJob::OnRegistrationFound(

ServiceWorkerStatusCode status,

- const scoped_refptr<ServiceWorkerRegistration>& registration) {

+ scoped_refptr<ServiceWorkerRegistration> registration) {

if (status == SERVICE_WORKER_ERROR_NOT_FOUND) {

DCHECK(!registration.get());

Complete(kInvalidServiceWorkerRegistrationId,