Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 2db3464318f900b4b407e646fcaf8c8ae9359e90..cd1abb63b7a6a3a410fc38fc54df8f1eeb731ef6 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -823,7 +823,7 @@ void ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker(
const GURL& other_url,
const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,
ServiceWorkerStatusCode status,
- const scoped_refptr<ServiceWorkerRegistration>& registration) {
+ scoped_refptr<ServiceWorkerRegistration> registration) {
if (status != SERVICE_WORKER_OK) {
callback.Run(false);
return;
@@ -852,7 +852,7 @@ void ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker(
void ServiceWorkerContextCore::OnRegistrationFinishedForCheckHasServiceWorker(
const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,
- const scoped_refptr<ServiceWorkerRegistration>& registration) {
+ scoped_refptr<ServiceWorkerRegistration> registration) {
callback.Run(registration->active_version() ||
registration->waiting_version());
}

Powered by Google App Engine
This is Rietveld 408576698