content/browser/service_worker/service_worker_context_core.cc - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.cc

diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc

index 2db3464318f900b4b407e646fcaf8c8ae9359e90..cd1abb63b7a6a3a410fc38fc54df8f1eeb731ef6 100644

--- a/content/browser/service_worker/service_worker_context_core.cc

+++ b/content/browser/service_worker/service_worker_context_core.cc

@@ -823,7 +823,7 @@ void ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker(

const GURL& other_url,

const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,

ServiceWorkerStatusCode status,

- const scoped_refptr<ServiceWorkerRegistration>& registration) {

+ scoped_refptr<ServiceWorkerRegistration> registration) {

if (status != SERVICE_WORKER_OK) {

callback.Run(false);

return;

@@ -852,7 +852,7 @@ void ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker(

void ServiceWorkerContextCore::OnRegistrationFinishedForCheckHasServiceWorker(

const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,

- const scoped_refptr<ServiceWorkerRegistration>& registration) {

+ scoped_refptr<ServiceWorkerRegistration> registration) {

callback.Run(registration->active_version() ||

registration->waiting_version());

}