content/browser/notifications/notification_event_dispatcher_impl.cc - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_event_dispatcher_impl.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/navigation_url_loader_impl_core.cc ('k') | content/browser/notifications/notification_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_event_dispatcher_impl.cc

diff --git a/content/browser/notifications/notification_event_dispatcher_impl.cc b/content/browser/notifications/notification_event_dispatcher_impl.cc

index 032d50362f57014fb42049d7baf0f094b9e8b7d0..7c3c0586afd063390471a58b0b686c801f38caf6 100644

--- a/content/browser/notifications/notification_event_dispatcher_impl.cc

+++ b/content/browser/notifications/notification_event_dispatcher_impl.cc

@@ -94,8 +94,7 @@ void DispatchNotificationEventOnRegistration(

const NotificationOperationCallback& dispatch_event_action,

const NotificationDispatchCompleteCallback& dispatch_error_callback,

ServiceWorkerStatusCode service_worker_status,

- const scoped_refptr<ServiceWorkerRegistration>&

- service_worker_registration) {

+ scoped_refptr<ServiceWorkerRegistration> service_worker_registration) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

#if defined(OS_ANDROID)

// This LOG(INFO) deliberately exists to help track down the cause of