Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: content/browser/background_sync/

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL:
Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/
diff --git a/content/browser/background_sync/ b/content/browser/background_sync/
index f4acfb7f31d763f2a72a828c1b075314b63acb89..a5c8b14e36681e65fbd9a7fcc896b0f18a8057b0 100644
--- a/content/browser/background_sync/
+++ b/content/browser/background_sync/
@@ -66,9 +66,9 @@ void RegisterServiceWorkerCallback(bool* called,
void FindServiceWorkerRegistrationCallback(
scoped_refptr<ServiceWorkerRegistration>* out_registration,
ServiceWorkerStatusCode status,
- const scoped_refptr<ServiceWorkerRegistration>& registration) {
+ scoped_refptr<ServiceWorkerRegistration> registration) {
EXPECT_EQ(SERVICE_WORKER_OK, status) << ServiceWorkerStatusToString(status);
- *out_registration = registration;
+ *out_registration = std::move(registration);
void UnregisterServiceWorkerCallback(bool* called,

Powered by Google App Engine
This is Rietveld 408576698