content/browser/service_worker/service_worker_version.h - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_unregister_job.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 417b301e117951038fa73907ad286404fd0233d9..db5392c1fcd62226bbc6a6b777293a67979c1e15 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -591,7 +591,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

bool is_browser_startup_complete,

const StatusCallback& callback,

ServiceWorkerStatusCode status,

- const scoped_refptr<ServiceWorkerRegistration>& registration);

+ scoped_refptr<ServiceWorkerRegistration> registration);

void StartWorkerInternal();

void DidSkipWaiting(int request_id);

@@ -639,7 +639,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

void FoundRegistrationForUpdate(

ServiceWorkerStatusCode status,

- const scoped_refptr<ServiceWorkerRegistration>& registration);

+ scoped_refptr<ServiceWorkerRegistration> registration);

void OnStoppedInternal(EmbeddedWorkerStatus old_status);