content/browser/loader/navigation_url_loader_impl_core.cc - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_impl_core.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/navigation_url_loader_impl_core.h ('k') | content/browser/notifications/notification_event_dispatcher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_impl_core.cc

diff --git a/content/browser/loader/navigation_url_loader_impl_core.cc b/content/browser/loader/navigation_url_loader_impl_core.cc

index 9ff2adaa78730a6598618aea6ecab356d47add9c..935cf0889a5a5b79f70e128aee6c20a7680ce941 100644

--- a/content/browser/loader/navigation_url_loader_impl_core.cc

+++ b/content/browser/loader/navigation_url_loader_impl_core.cc

@@ -147,8 +147,8 @@ void NavigationURLLoaderImplCore::NotifyRequestFailed(bool in_cache,

}

void NavigationURLLoaderImplCore::OnServiceWorkerChecksPerformed(

- ServiceWorkerStatusCode status,

- const scoped_refptr<ServiceWorkerRegistration>& registration) {

+ ServiceWorkerStatusCode status,

+ scoped_refptr<ServiceWorkerRegistration> registration) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

// If the navigation has a ServiceWorker, bail out immediately.

// TODO(clamy): only bail out when the ServiceWorker has a Fetch event