Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, aboxhall, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, je_julie, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce View: a named widget with the toolbar. BUG=627306 Committed: https://crrev.com/ca00017577716b2aa19bda3382fb88c2f7c80a1b Cr-Commit-Position: refs/heads/master@{#406484}

Patch Set 1 #

Patch Set 2 : lcean #

Patch Set 3 : lcean #

Patch Set 4 : lcean #

Patch Set 5 : rebaselined #

Total comments: 13

Patch Set 6 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -444 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 4 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/accessibilityNode.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/module.json View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 4 chunks +5 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/breakpointsList.css View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 2 3 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 8 chunks +13 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js View 3 chunks +5 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarView.js View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 3 chunks +21 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js View 3 chunks +3 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js View 3 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/FontView.js View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/ImageView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 4 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js View 5 chunks +31 lines, -91 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/ui/ThrottledView.js View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/ThrottledWidget.js View 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 1 2 3 4 5 1 chunk +68 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/sidebarPane.css View 1 2 3 3 chunks +7 lines, -37 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
pfeldman
4 years, 5 months ago (2016-07-18 23:40:59 UTC) #3
pfeldman
On 2016/07/18 23:40:59, pfeldman wrote: PTAL!
4 years, 5 months ago (2016-07-19 15:31:03 UTC) #4
dgozman
lgtm https://codereview.chromium.org/2157713002/diff/80001/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (left): https://codereview.chromium.org/2157713002/diff/80001/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#oldcode962 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:962: this.sidebarPanes.styles.expandPane(); Who does this now? https://codereview.chromium.org/2157713002/diff/80001/third_party/WebKit/Source/devtools/front_end/source_frame/FontView.js File third_party/WebKit/Source/devtools/front_end/source_frame/FontView.js ...
4 years, 5 months ago (2016-07-20 01:37:16 UTC) #11
pfeldman
https://codereview.chromium.org/2157713002/diff/80001/third_party/WebKit/Source/devtools/front_end/ui/Widget.js File third_party/WebKit/Source/devtools/front_end/ui/Widget.js (right): https://codereview.chromium.org/2157713002/diff/80001/third_party/WebKit/Source/devtools/front_end/ui/Widget.js#newcode664 third_party/WebKit/Source/devtools/front_end/ui/Widget.js:664: if (this._setRevealRequested) On 2016/07/20 01:37:16, dgozman wrote: > delete ...
4 years, 5 months ago (2016-07-20 01:45:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157713002/100001
4 years, 5 months ago (2016-07-20 01:48:05 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-20 04:26:56 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 04:27:10 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:28:46 UTC) #20
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/ca00017577716b2aa19bda3382fb88c2f7c80a1b
Cr-Commit-Position: refs/heads/master@{#406484}

Powered by Google App Engine
This is Rietveld 408576698